Ticket #11359 (closed: fixed)
Promote MD CoordinateSystem to member in MD workspaces
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #11350 | Tester: | Owen Arnold |
Description
Currently, the MD workspace stores the value for its coordinate system in a log on the first experiment info within the workspace. This field really applies to the workspace as a whole and not a particular run so it should be a separate field in the class and saved file.
This was uncovered in #11350 and will avoid having to load an experiment info when it is file backed just to set a single field.
Change History
comment:2 Changed 6 years ago by Martyn Gigg
- Status changed from new to inprogress
Store the MD coordinate system in its own field.
Refs #11359
Changeset: 181db647a8435f2bec56975402a0c769c5c60376
comment:3 Changed 6 years ago by Martyn Gigg
Load and save the MD coordinate system
Backwards compatability is preserved by checking for the log as it would have existed. Refs #11359
Changeset: e053866e88944edcd36cc75d3beb5d3327633a93
comment:4 Changed 6 years ago by Martyn Gigg
Formatting changes before the real changes.
Refs #11359
Changeset: c97d33c7a122b7125c799a10a09be0145d1fba9e
comment:5 Changed 6 years ago by Martyn Gigg
Load and save coordinate field in PeaksWorkspace.
It is still backwards compatible with the old log-entry format. Refs #11359
Changeset: cee29dc758aa3c8b3ff93e438e352f917eb52f09
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #407.
comment:7 Changed 6 years ago by Martyn Gigg
Copy coordinate system to new workspaces
This used to be done by copying the experiment info but is handled separately now that the coordinate is an extra field. Refs #11359
Changeset: d78fd4db26c1b70f046dda58b33e5ceaab2ffdcb
comment:8 Changed 6 years ago by Martyn Gigg
W Matrix has been removed as it was unused.
Refs #11359
Changeset: 489eedc8f866a696a7a091879aad436e70ae79b6
comment:9 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:10 Changed 6 years ago by Owen Arnold
jenkins retest this please
comment:11 Changed 6 years ago by Martyn Gigg
Include HDF5 for MDAlgorithmsTest
On Windows they are in a non-standard location so must be explicitly included. Refs #11359
Changeset: 82ce4e6a6dcdabe3e4bd5318ef1278b106ec5abf
comment:12 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please
comment:13 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please
comment:14 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please
comment:15 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge pull request #407 from mantidproject/11359_md_coordinate_as_own_field
MD coordinate as separate field
Full changeset: 574efd1fe23cc214c201dada4126d59a3a3ae0df
comment:16 Changed 6 years ago by Owen Arnold
Code looks good, and I've tested this for both Peaks and MDWorkspaces.
comment:17 Changed 6 years ago by Martyn Gigg
Merge branch '11359_md_coordinate_as_own_field' into 11350_converttomd_no_expt_info_loading
Conflicts:
Code/Mantid/Framework/MDEvents/src/MDEventWorkspace.cpp
Refs #11350
Full changeset: bacb8b42e87bb737fc99ad844b9011fd729f98db
comment:18 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12198
Owen noted that we should also do this for a PeaksWorkspace.