Ticket #11362 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Change the saved structure of MDHisto from SaveMD

Reported by: Ross Whitfield Owned by: Ross Whitfield
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

This will be version 2 of SaveMD and will change the structure of how a MDHisto will be saved. This will help users with using the output from SaveMD in other software and will make the files more NeXus compliant.

Instead of saving the 'signal' (also 'errors_squared', 'num_events' and 'mask') as a one dimensional array, it will be saved as the correct multi-dimension of array.

The axes will also be saved as a data array, not an XML string attribute of the top group.

The LoadMD will be changed to read in the new structure but will still support the SaveMD v1 format.

Change History

comment:1 Changed 6 years ago by Ross Whitfield

  • Status changed from new to inprogress

Refs #11362 Create SaveMD v2, saves multi-dim signal.

Changeset: 907d31d9a3d5198d728b9aa9df9d81bf67add995

comment:2 Changed 6 years ago by Ross Whitfield

Refs #11362 Create SaveMD v2, saves multi-dim signal.

Changeset: 06b4c892c5525de337af5dbd5bc3a792dfc53840

comment:3 Changed 6 years ago by Ross Whitfield

  • Milestone changed from Release 3.4 to Release 3.5

comment:4 Changed 5 years ago by Ross Whitfield

Refs #11362 If MDEventWorkspace then use SaveMD Version 1.

Changeset: f468a0d7cf4b0ff2aa59f63e0d6c26ffa2fca572

comment:5 Changed 5 years ago by Ross Whitfield

Refs #11362 Add SaveMDVersion attribute to MDHistoWorkspace group.

Changeset: adc0024f5e954ef1b5c649520596f418010f7e75

comment:6 Changed 5 years ago by Ross Whitfield

Refs #11362 Save axes as arrays.

Changeset: e34d8b629c0c18d214cf5d18c98417ade257f6ee

comment:7 Changed 5 years ago by Ross Whitfield

Refs #11362 Add axes and signal as attribute to 'signal'.

Changeset: bc8534c638161e5da00dd4d49c8e807b99726393

comment:8 Changed 5 years ago by Ross Whitfield

Refs #11362 Add long_name to axis.

Changeset: 769d3aded2419094604efd4915b89ab307f44c96

comment:9 Changed 5 years ago by Ross Whitfield

Refs #11362 clang-format it.

Changeset: a30558cee4de97d0b981721e78822fa3b994241a

comment:10 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix error in writing axes.

Changeset: 0813912e7d1a335ff2a8915ff6e664ff4fb56946

comment:11 Changed 5 years ago by Ross Whitfield

Refs #11362 Make LoadMD able to read multi-Dim data.

Changeset: b76b8413d65cddad4170d041711419af3b55be2b

comment:12 Changed 5 years ago by Ross Whitfield

Refs #11362 Look for SaveMDVersion then load axes appropriately.

Changeset: dbce9ec68207ef859da0aa71c96b8572efd94f31

comment:13 Changed 5 years ago by Ross Whitfield

Refs #11362 Remove now unneeded things in SaveMD v2.

Changeset: 0c34448ce8b02a233d26b1ebb440c300a7eeb1ab

comment:14 Changed 5 years ago by Ross Whitfield

Refs #11362 Add docs for SaveMD v2.

Changeset: ab9ecc2919747d23fbd6e5b369835503636e2bc9

comment:15 Changed 5 years ago by Ross Whitfield

Refs #11362 Add unit tests for SaveMD v2. (Copied from SaveMD v1).

Changeset: aa3edb5648273405aebd5b8c3fec6f5022ea527f

comment:16 Changed 5 years ago by Ross Whitfield

  • Milestone changed from Release 3.5 to Release 3.4

comment:17 Changed 5 years ago by Ross Whitfield

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #646.

comment:18 Changed 5 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:19 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix that thing.

Changeset: 630cf6cc9d9b951bc8ae1ca0028061755d1105d0

comment:20 Changed 5 years ago by Ross Whitfield

Refs #11362 Remove unneeded stuff from header.

Changeset: 3c50ade1674fdb46b92da9d60cbf6c1a80ac84b2

comment:21 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix that other thing.

Changeset: ef93235eb82cde08b6059e61011f5dacfe39f09b

comment:22 Changed 5 years ago by Ross Whitfield

@OwenArnold @abuts You may want to look at this also.

comment:23 Changed 5 years ago by Ross Whitfield

Refs #11362 Create SaveMD v2, saves multi-dim signal.

Changeset: 06b4c892c5525de337af5dbd5bc3a792dfc53840

comment:24 Changed 5 years ago by Ross Whitfield

Refs #11362 If MDEventWorkspace then use SaveMD Version 1.

Changeset: f468a0d7cf4b0ff2aa59f63e0d6c26ffa2fca572

comment:25 Changed 5 years ago by Ross Whitfield

Refs #11362 Add SaveMDVersion attribute to MDHistoWorkspace group.

Changeset: adc0024f5e954ef1b5c649520596f418010f7e75

comment:26 Changed 5 years ago by Ross Whitfield

Refs #11362 Save axes as arrays.

Changeset: e34d8b629c0c18d214cf5d18c98417ade257f6ee

comment:27 Changed 5 years ago by Ross Whitfield

Refs #11362 Add axes and signal as attribute to 'signal'.

Changeset: bc8534c638161e5da00dd4d49c8e807b99726393

comment:28 Changed 5 years ago by Ross Whitfield

Refs #11362 Add long_name to axis.

Changeset: 769d3aded2419094604efd4915b89ab307f44c96

comment:29 Changed 5 years ago by Ross Whitfield

Refs #11362 clang-format it.

Changeset: a30558cee4de97d0b981721e78822fa3b994241a

comment:30 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix error in writing axes.

Changeset: 0813912e7d1a335ff2a8915ff6e664ff4fb56946

comment:31 Changed 5 years ago by Ross Whitfield

Refs #11362 Make LoadMD able to read multi-Dim data.

Changeset: b76b8413d65cddad4170d041711419af3b55be2b

comment:32 Changed 5 years ago by Ross Whitfield

Refs #11362 Look for SaveMDVersion then load axes appropriately.

Changeset: dbce9ec68207ef859da0aa71c96b8572efd94f31

comment:33 Changed 5 years ago by Ross Whitfield

Refs #11362 Remove now unneeded things in SaveMD v2.

Changeset: 0c34448ce8b02a233d26b1ebb440c300a7eeb1ab

comment:34 Changed 5 years ago by Ross Whitfield

Refs #11362 Add docs for SaveMD v2.

Changeset: ab9ecc2919747d23fbd6e5b369835503636e2bc9

comment:35 Changed 5 years ago by Ross Whitfield

Refs #11362 Add unit tests for SaveMD v2. (Copied from SaveMD v1).

Changeset: aa3edb5648273405aebd5b8c3fec6f5022ea527f

comment:36 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix that thing.

Changeset: 630cf6cc9d9b951bc8ae1ca0028061755d1105d0

comment:37 Changed 5 years ago by Ross Whitfield

Refs #11362 Remove unneeded stuff from header.

Changeset: 3c50ade1674fdb46b92da9d60cbf6c1a80ac84b2

comment:38 Changed 5 years ago by Ross Whitfield

Refs #11362 Fix that other thing.

Changeset: ef93235eb82cde08b6059e61011f5dacfe39f09b

comment:39 Changed 5 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #646 from mantidproject/11362_SaveMD_MDHisto_structure_change

Change SaveMD structure for MDHisto

Full changeset: ​1396a3edb60a49e56e97aeb8ac0914959841e77d

comment:40 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12201

Note: See TracTickets for help on using tickets.