Ticket #11377 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

DataSelector: dataReady fired when data has not changed

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Karl Palmen

Description

Focusing and unfocusing from the file selection fires dataReady(), this should only happen once when the file is found.

I previously fixed this in MWRunFiles, DataSelector just needs to use this slot instead.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Only emit the signal when the data has changed

Refs #11377

Changeset: 7e9ac8f6d31e544a9def4056b23cba0d644138e0

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #409.

comment:4 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added

comment:5 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge pull request #409 from mantidproject/11377_dataselector_dataready_signal_issue

DataSelector only emit dataReady signal when data changed

Full changeset: ​1222c4838d0f60b424ce2bd937050c4aa1fca930

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12216

Note: See TracTickets for help on using tickets.