Ticket #11394 (closed: fixed)
Fix ET Plot Time issue
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Karl Palmen |
Description
Using Plot Time in IDR>ET gives an exception and no plot.
Change History
comment:1 Changed 6 years ago by Dan Nixon
- Status changed from new to assigned
- Milestone changed from Backlog to Release 3.4
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #420.
comment:4 Changed 6 years ago by Dan Nixon
Move spectrum selection to additional UI inputs
Previously could not plot time on a monitor
Refs #11394
Changeset: 7026a374f0f3cef0aa93ef86b5ed14789c8b7d8c
comment:8 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:9 Changed 6 years ago by Karl Palmen
It does not work for me. I get exception when I try it on Windows 7. Test failed.
comment:10 Changed 6 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Fix new exception Refs #11394
Changeset: ef31ebcedac5f040d1c11cce83eb0745e4260520
comment:12 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:14 Changed 6 years ago by Karl Palmen
I still get a type exception for the minimum spectrum.
comment:15 Changed 6 years ago by Karl Palmen
- Status changed from verify to reopened
- Resolution fixed deleted
comment:16 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Use correct type for spectra properties
Refs #11394
Changeset: 888e1e29126521f998904dd02c0aa8b8c14994ce
comment:17 Changed 6 years ago by Dan Nixon
Merge branch '11394_fix_et_plot_time' of github.com:mantidproject/mantid into 11394_fix_et_plot_time
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ISISEnergyTransfer.cpp
Refs #11394
Changeset: e3a73aed3a194f09f5dd8b32ac044b3c32afbc0b
comment:18 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:19 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:20 Changed 6 years ago by Karl Palmen
The test makes more progress but fails having successfully run several child algorithms. It fails with a type error when it loads again.
The error shown to the results log is: InelasticIndirectReduction successful, Duration 2.30 seconds Load started Cannot process ICPevent log. Period 1 assumed for all data. Load successful, Duration 2.59 seconds Algorithm property given value of incorrect type. Stopping queue execution. Got error from algorithm "GroupDetectors" Stopping batch algorithm because of execution error
comment:21 Changed 6 years ago by Karl Palmen
- Status changed from verify to reopened
- Resolution fixed deleted
comment:22 Changed 6 years ago by Dan Nixon
@KarlPalmen Actually now that you mention GroupDetectors I have noticed another issue with the routine that needs to be fixed.
comment:23 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Fix issue with range of grouped dets
Refs #11394
Changeset: 5c8a8e81334951ff42f1edd055b06f7192e2ef59
comment:24 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:25 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:26 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:27 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:28 Changed 6 years ago by Dan Nixon
I've given up trying to get the CI to pass on this, over the last 3 retests it has passed on all platforms so should be OK to be tested now.
comment:29 Changed 6 years ago by Karl Palmen
It works for me (on Windows 7).
comment:30 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:31 Changed 6 years ago by Karl Palmen
It works again, but I have noticed, that when I plot again and create a new graph in a new window, the previous graphs are updated to look like the new graph. Is this supposed to happen?
comment:32 Changed 6 years ago by Dan Nixon
@KarlPalmen That's just an issue with plotting, it happens on quite a few indirect interfaces. There is an existing [ticket](http://trac.mantidproject.org/mantid/ticket/8236) to fix this.
comment:33 Changed 6 years ago by Dan Nixon
I think this should be OK to merge, I have well and truly given up with Jenkins now, everything that needs to have passed has passed (just not at the same time).
comment:34 Changed 6 years ago by Nick Draper
comment:35 Changed 6 years ago by Dan Nixon
- Status changed from verify to closed
Merge branch '11394_fix_et_plot_time' of github.com:mantidproject/mantid into 11394_fix_et_plot_time
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ISISEnergyTransfer.cpp
Refs #11394
Full changeset: e3a73aed3a194f09f5dd8b32ac044b3c32afbc0b
comment:36 Changed 6 years ago by Karl Palmen
Merge pull request #420 from mantidproject/11394_fix_et_plot_time
Fix exception on ISIS Energy Transfer > Plot Time
Full changeset: 98b89268ed3babe8923289ce6ceeabb85975dda1
comment:37 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12233