Ticket #11397 (closed)

Opened 6 years ago

Last modified 5 years ago

Ensure LoadMask in direct inelastic use IDF name rather then instrumet name

Reported by: Alex Buts Owned by: Alex Buts
Priority: blocker Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description (last modified by Alex Buts) (diff)

This to avoid existing bug in LoadMask, referenced by ticket #11395

In addition to that, number of other minor bugs or features were identified after new reduction has been run on instruments and used not exactly as initially supposed. This ticket is a good wrapper to address the identified issues.

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Summary changed from Ensure LoadMask in direct inelastic use IDF name rather then instrumnet name to Ensure LoadMask in direct inelastic use IDF name rather then instrumet name

comment:2 Changed 6 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

Re #11397 Mask workspace become lost

when sctipt has been stopped in the middle of the calculations and started again. It is not to fail on printing diagnostics results.

Changeset: 5c6cfc41877e59808bc9d23efca575db894cbc0e

comment:5 Changed 6 years ago by Alex Buts

Re #11397 Custom file name function does not work in multirep mode

Surprisingly it has been working before.

Changeset: eb6b2f465c9fc7c531afbd0b9ff4977f9c6b7788

comment:6 Changed 6 years ago by Alex Buts

Re #11397 Stub to allow heterogeneous binning of monitor workspace.

(incompleted)

Changeset: e32c35b292457b216b357a2f3a9ec61a8c22b4d2

comment:7 Changed 6 years ago by Alex Buts

Re #11397 Dealt with the issue, mentioned in the ticket.

A load mask gets fully defined IDF to avoid problems with fining this file from instrument name.

Changeset: 3e65d9ff9ef986db57c032ea5550ff74c4503f5d

comment:8 Changed 6 years ago by Alex Buts

Re #11397 Make better protection for masking workspace property value

for case when script stopped by user and then restarted.

Changeset: aeee5d734d32908d6f8089e0dca00bc8b69639f1

comment:9 Changed 6 years ago by Alex Buts

Re #11397 Minor typo

Changeset: bc3e8f073d692f2d9b354bcaf732086d2eaa9510

comment:10 Changed 6 years ago by Alex Buts

Re #11397 Unit test for workspaces with heterogeneous binning

Changeset: 4f4dbb9a53b68a1e88474dd6a46cd421c85ae950

comment:11 Changed 6 years ago by Alex Buts

It is addressed as pull request ​https://github.com/mantidproject/mantid/pull/433

comment:12 Changed 6 years ago by Alex Buts

Re #11397 Unit test for custom file name

Changeset: 14af060915f4b4ee276fd60c3ae6dee8fcc79e09

comment:13 Changed 6 years ago by Alex Buts

Re #11397 fixing DirectPropertyManagerTest

and more unit tests for custom print function

Changeset: 081c899e802928b53d4153bac36aaa5f27b5224b

comment:14 Changed 6 years ago by Alex Buts

Re #11397 Should fix issue with custom print function

Changeset: c096241696e29323f0fa187074f81929cc10fffa

comment:15 Changed 6 years ago by Alex Buts

Re #11397 Better testing for Multirep ranges routine

Changeset: 5bfd5a92adf3a9e0e6d427e95d8a8bdcde67370f

comment:16 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verifying
  • Tester set to Federico Montesino Pouzols

comment:17 Changed 6 years ago by Federico Montesino Pouzols

All looks fine. I also run all the ISIS system tests locally and there were no issues.

comment:18 Changed 6 years ago by Alex Buts

Re #11397 Custom file name function does not work in multirep mode

Surprisingly it has been working before.

Changeset: eb6b2f465c9fc7c531afbd0b9ff4977f9c6b7788

comment:19 Changed 6 years ago by Alex Buts

Re #11397 Stub to allow heterogeneous binning of monitor workspace.

(incompleted)

Changeset: e32c35b292457b216b357a2f3a9ec61a8c22b4d2

comment:20 Changed 6 years ago by Alex Buts

Re #11397 Dealt with the issue, mentioned in the ticket.

A load mask gets fully defined IDF to avoid problems with fining this file from instrument name.

Changeset: 3e65d9ff9ef986db57c032ea5550ff74c4503f5d

comment:21 Changed 6 years ago by Alex Buts

Re #11397 Make better protection for masking workspace property value

for case when script stopped by user and then restarted.

Changeset: aeee5d734d32908d6f8089e0dca00bc8b69639f1

comment:22 Changed 6 years ago by Alex Buts

Re #11397 Minor typo

Changeset: bc3e8f073d692f2d9b354bcaf732086d2eaa9510

comment:23 Changed 6 years ago by Alex Buts

Re #11397 Unit test for workspaces with heterogeneous binning

Changeset: 4f4dbb9a53b68a1e88474dd6a46cd421c85ae950

comment:24 Changed 6 years ago by Alex Buts

Re #11397 Unit test for custom file name

Changeset: 14af060915f4b4ee276fd60c3ae6dee8fcc79e09

comment:25 Changed 6 years ago by Alex Buts

Re #11397 fixing DirectPropertyManagerTest

and more unit tests for custom print function

Changeset: 081c899e802928b53d4153bac36aaa5f27b5224b

comment:26 Changed 6 years ago by Alex Buts

Re #11397 Should fix issue with custom print function

Changeset: c096241696e29323f0fa187074f81929cc10fffa

comment:27 Changed 6 years ago by Alex Buts

Re #11397 Better testing for Multirep ranges routine

Changeset: 5bfd5a92adf3a9e0e6d427e95d8a8bdcde67370f

comment:28 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #433 from mantidproject/11397_BugsInDirectInelastic

Minor bugs and enhancements in Direct inelastic reuction

Full changeset: ​585985fa991a05abc26625c9a82a6dd4c519c030

comment:29 Changed 6 years ago by Federico Montesino Pouzols

Related to this, the option to FileFinder to skip directories has just been merged: #435

comment:30 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12236

Note: See TracTickets for help on using tickets.