Ticket #11400 (closed: fixed)
add -pedantic to gcc and clang warnings
| Reported by: | Steven Hahn | Owned by: | Steven Hahn |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Andrei Savici |
Description
On slack, we decided to enable the -pedantic compiler flag on the compilers that support it. Before making this change on master, we must first fix all warnings generated with -pedantic enabled.
Change History
comment:2 Changed 6 years ago by Steven Hahn
- Status changed from new to inprogress
Refs #11400. Fix all warning on OSX 10.9
Changeset: 3e626a056b936b282cdaa299e534b24afc9d54a2
comment:3 Changed 6 years ago by Steven Hahn
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #425.
comment:4 Changed 6 years ago by Steven Hahn
Refs #11400. fix warning in tests. [ci skip]
Changeset: 5c107da2b5f089025418ca14338a11c47e141e38
comment:6 Changed 6 years ago by Harry Jeffery
@quantumsteve I've created a commit that fixes the extra ';' warnings. How would you like me to send it to you? I can either send you a .patch, or push the commit straight to this branch.
comment:7 Changed 6 years ago by Harry Jeffery
Refs #11400 Fix extra ';' warnings
Changeset: 9fd8d1b1407aee651602e7ba5a32bab2094d8039
comment:8 Changed 6 years ago by Steven Hahn
Refs #11400. Mark ParaView and SIP headers as system headers.
Changeset: 77f0d75e27b73fbfcce8bd34b6451dd0af04e0fb
comment:9 Changed 6 years ago by Steven Hahn
Refs #11400. Use variatic template in place of variatic macro.
Changeset: 00badb07aa993cc253f8be14e8ed5c38a7b5a389
comment:10 Changed 6 years ago by Steven Hahn
Refs #11400. use include_directories to include paraview headers.
Changeset: 130ba5ca77cfa6610a0d0c75decd9a4f7fb4108b
comment:11 Changed 6 years ago by Steven Hahn
Refs #11400. Change warning style.
Changeset: 0275d97bbeec692a96d008bb9ce60f517b229d36
comment:12 Changed 6 years ago by Steven Hahn
Refs #11400. use union to fix casting warnings.
Changeset: 4ea831cfd463ec72a204c1e5069d783495b1d912
comment:13 Changed 6 years ago by Steven Hahn
skip ci
comment:14 Changed 6 years ago by Steven Hahn
Refs #11400. use macros on platforms without variatic templates.
Changeset: 3c449fc9aad8813344acd2c04d6397625555ba6e
comment:15 Changed 6 years ago by Steven Hahn
Refs #11400. RHEL 6 fixes for extra comma and semicolon.
Changeset: ba594221a430a83882515c5fad3e102e44b32287
comment:16 Changed 6 years ago by Steven Hahn
Refs #11400. Suppress warnings in sip we cannot control.
Changeset: fb865b2f332cf7731ae93870c12c6a7c028a0261
comment:17 Changed 6 years ago by Steven Hahn
Refs #11400. Cleanup sip and python-related warnings.
Changeset: efe2dbe764e9e7d5203d9f4b74a98a46aa1c106e
comment:18 Changed 6 years ago by Steven Hahn
Refs #11400. use older numpy iterator functions.
Changeset: 9762dfb4ba2bfaab5a4e8df0055bd987ae0ba162
comment:19 Changed 6 years ago by Martyn Gigg
Disable all warnings from sip-generated code.
As the code is entirely autogenerated we can't do anything about it. Refs #11400
Changeset: 64941ad4a2bad550c9baa490a243be1cce82d2ec
comment:20 Changed 6 years ago by Martyn Gigg
Ignore all warnings in MantidQt sip code.
Refs #11400
Changeset: 13844e2206a759e7b91443c67c4f7e3146e55098
comment:21 Changed 6 years ago by Steven Hahn
Refs #11400. Suppress numpy warning by moving to a separate file.
Changeset: dd52656a09cf0b3f8101864f0985b3530185b139
comment:22 Changed 6 years ago by Steven Hahn
Refs #11400. Include paraview headers as system headers.
Changeset: 6ecdb656c166ec0e1e4367ee41186a09c17ec992
comment:23 Changed 6 years ago by Steven Hahn
Refs #11400. Remove old code from cpp files.
Changeset: 132fb1148b56158a2afd01043b0cddc53ffb7872
comment:24 Changed 6 years ago by Steven Hahn
Refs #11400. Change warning flag for rhel6. remove extra ;.
Changeset: 9d13c5510c48118e3e572a90d27d91b4207d3106
comment:25 Changed 6 years ago by Steven Hahn
Refs #11400. #ifdef around gcc #pragma.
Changeset: 65a64f42d147fdd29478e83661710585c1e0cccd
comment:26 Changed 6 years ago by Steven Hahn
retest this please
comment:27 Changed 6 years ago by Steven Hahn
Refs #11400. Remove pedantic and Wno-unused-result when gcc=4.4
Changeset: 2d950287102693b8a3eb8454d7e28ef0af85e62f
comment:28 Changed 6 years ago by Steven Hahn
previous commit removes -pedantic from rhel6. I tried building on another rhel6 machine and don't see the warnings listed on the build server.
comment:29 Changed 6 years ago by Steven Hahn
retest this please
comment:30 Changed 6 years ago by Steven Hahn
Refs #11400. Change VERSION_GREATER to NOT VERSION_LESS.
Changeset: 64d9a6dc3689c003caffbc772b4ccef838b391b0
comment:31 Changed 6 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:32 Changed 6 years ago by Andrei Savici
- Status changed from verifying to closed
Merge pull request #425 from mantidproject/11400_enable_fix_pedantic_warnings
Enable and fix all pedantic warnings
Full changeset: 49eb386e2254691cc07165dd3363ff87ceb72396
comment:33 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:34 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12239
801 warnings on OS X 10.9
https://gist.github.com/quantumsteve/616c5124282f3e7fde09