Ticket #11420 (new)

Opened 6 years ago

Last modified 5 years ago

LoadMask: speed up and improve error message

Reported by: Federico M Pouzols Owned by:
Priority: minor Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Federico M Pouzols) (diff)

This comes from [PR 435](​https://github.com/mantidproject/mantid/pull/435). Here are two aspects that could be improved in LoadMask:

  • LoadMask can be slowish for what it does. With LET and LET_hard.msk it takes 'too long'. I guess that the problem is the large number of histograms, but to get a 9MB workspace you have to wait many seconds and it even looks as if it had hanged). Investigate and see if it can be sped up and/or parallelized. Or, at least, the progress report could be updated so the user gets some feedback and an idea of how much time the load is going to take.
  • If you try to LoadMask with a wrong combination (for example LoadMask('MAR', 'LET_hard.msk'), you'll get a cryptic error message: RuntimeError: Logic error.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:2 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:3 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12259

Note: See TracTickets for help on using tickets.