Ticket #11435 (closed: fixed)
Adaptive radius binning Test
| Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Diffraction | Keywords: | |
| Cc: | federico.montesino-pouzols@… | Blocked By: | |
| Blocking: | Tester: | Federico Montesino Pouzols |
Description
(by Federico Montesino Pouzols): I'd suggest adding a test case in IntegratePeaksMD2Test to cover the two new properties added in #11005. Or, if this is not feasible with the small/toy data available in unit tests, maybe something along the lines of the test script given in the PR description could be added in the system tests. I'm not very familiar with those system tests, but at first look Diffraction_Workflow_Test seems a good place.
Change History
comment:2 Changed 6 years ago by anonymous
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #490.
comment:3 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:5 Changed 6 years ago by Federico Montesino Pouzols
This extends the unit test IntegratePeaksMD2 to cover new properties that were added in a previous ticket. It all looks good and seems to be working well. We got unrelated test failures on two platforms (two well known friends: LoadFullprofResolutionTest which lately tends to be dizzy, and the MERLIN system test on rhel7). I'd put my hand in the fire that this is just fine.
comment:9 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #490 from mantidproject/11435_adaptive_test
Test adaptive radius integration
Full changeset: 84ea0e61d61d6127e12945ef656ab5f065213856
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12274
Refs #11435 test adaptive Q integration
Changeset: 5bff5c4441a2c9446683c19d7c48c0ac90532185