Enable "force file extension" and hide result validation options on ISISDirectInelastic

[Alex Buts]

These issues revealed during running direct inelastic "ConvertToEnergy" workflow during the cycle and are easy to fix.

The first one related to "waiting for files" option. Very often system generates raw file first and nxs file is not yet ready and user wants to process nxs files. Reduction fails for raw files as they are inappropriate.

When "Wait for file" option is enabled, system should wait for the files with specific extension.

Second one came after discussion with the group and the group wants less information on how to build validation results. Only property run_vailde_on_run (number) should be exposed to user.

These two issues may be considered as trivial but are important for usability.

[Alex Buts]

Re #11445 Diagnostics message if IDF does not contain property:

multirep_tof_specta_list

Changeset: 39dc401b2257036814251e240c82825bfb548729

[Alex Buts]

Re #11445 Set up Web_vars at construction

and started moving validation out of users.

Changeset: aea5c54087c7b7ab3eaf22526764121277ebbad2

[Alex Buts]

Re #11445 Changed validation procedure to hide it from users

Changeset: 0764281bb9c84209865c7a09346744a10f73140a

[Alex Buts]

Re #11445 Merge branch 'master' into11445_ReductionWrapperEnhancements

Conflicts:

Code/Mantid/scripts/Inelastic/Direct/DirectEnergyConversion.py

Changeset: ae520a8ea177776ca200819088a9e551bda98008

[Alex Buts]

Re #11445 ReductionWrapper validate_run_number property

instead if validate_result method. validate_result is still possible but may be used internally.

Changeset: 4c646aa4420de920cc4804443a45f5ac91004b62

[Alex Buts]

Re #11445 Unit test to check that ReductionWrapper accepts vars in

constructor. This is to ensure that ReductionWrapper works with web services.

Changeset: 419b103485ef13e5a87a66777dec63154ef68991

[Alex Buts]

Re #11445 Intermediate checkout -- load sXX files

Changeset: d975a98da67524f4b056b2f35c85d2e5aaf4fcc3

[Alex Buts]

Re #11445 Fixed issue with runnumber == 0

and removed spurious file extensions lists (they do not belong to RunDescriptor)

Changeset: f70a50fcbb83b7f6124d247feecc65af79dc4694

[Alex Buts]

Re #11445 Minor bugs and stability issues introduced by previous

changes

Changeset: 5fa58b7f5efb9d2f409f2f5838d8939f930fae58

[Alex Buts]

Re #11445 Implemented wait for file with specified extension

Changeset: 1434c294008f48b1ffd9d40882e8cead63327d5d

[Alex Buts]

Re #11445 Fixed issues with reduction failing if all workspaces

are cleaned up from Mantid

Changeset: fc816f92e8f649d2629ccdbce8217cdc2891d540

[Alex Buts]

Re #11445 Bug in returning _file_name property

Changeset: 362381c21bd337566f01066e796f3063219c2296

[Alex Buts]

Its fixed as PR ​https://github.com/mantidproject/mantid/pull/511

Here are number of small bug-fixes and enhancements based on instrument scientists feedback, identified when running ISIS direct inelastic reduction on the instruments during the cycle #14_3

They are mainly related to "transitional" operational modes which difficult to test or reproduce but always happen during normal operations, e.g. when IS want to reduce "0" run or somebody decides to clean-up intermediate reduced workspaces or DAE returns nxs file requested some time after providing raw file which can not be reduced in specific experiment.

Almost every commit refers to minor issue observed during operations. As soon as all tests pass, the code validity can be considered proven. There are various ways of running reduction so number of errors can happen when things are set up, so I would suggest tester to rely on the system tests for DirectInelastic to prove things work fine. Best way of testing this ticket is by a code review.

I will enrol changes to the instruments immediately after the tests have passed.

[Alex Buts]

Re #11445 Should fix unit test

Changeset: a02e1bc7c982a800c236e3c2e377db44d1dc1b61

[Roman Tolchenov]

Merge pull request #511 from mantidproject/11445_ReductionWrapperEnhancements

Minor bugs and enhancements in Direct inelastic reuction

Full changeset: ​24f0de86ccefe4cebbda02c2e8a9c01420dbd7ce

[Stuart Campbell]

This ticket has been transferred to github issue ​12284