Ticket #1145 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

LoadMuonNexus should work for both version 1 and 2

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: blocker Milestone: Iteration 22
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

  1. loadmuonnexus2 should be renamed to LoadMuonNexus version 2
  2. Step 1 in exec of LoadMuonNexus version 2 is to work out if it is a version 1 file and call loadMuonNexus version 1. This could be done as a sub algorithm or by inheritance and calling the base exec.
  3. If Autogroup is not implpmented for version 2 files and autogroup is selected, the algorithm should output a warning to the log.
  4. Any commented out code should be removed or Comments should explicitly explain the reasons for it remaining and what it does.

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Summary changed from LoadMuoNexus should work for both version 1 and 2 to LoadMuonNexus should work for both version 1 and 2

comment:2 Changed 11 years ago by Roman Tolchenov

(In [4001]) LoadMuonNexus2 works for both muon versions. re #1145

comment:3 Changed 11 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 11 years ago by Roman Tolchenov

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 11 years ago by Anders Markvardsen

  • Status changed from testing to reopened
  • Resolution fixed deleted

comment:6 Changed 11 years ago by Anders Markvardsen

(In [4211]) Removed unused code comments in LoadMuonNexus2. Refs #1145.

comment:7 Changed 11 years ago by Anders Markvardsen

  • Status changed from reopened to testing
  • Resolution set to fixed

comment:8 Changed 11 years ago by Anders Markvardsen

  • Status changed from testing to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1993

Note: See TracTickets for help on using tickets.