Ticket #11463 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

DNS IDF does not validate against the schema

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

The IDF validation reports an error:

VALIDATION OF 'C:/MantidInstall/instrument/DNS_Definition_PAonly.xml' FAILED WITH ERROR:

ERROR: DNS_Definition_PAonly.xml: line 3: Used root tag (None, u'instrument') not found in schema file(s)!

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to inprogress

The instrument tag is missing the xsd definition attributes.

comment:2 Changed 6 years ago by Martyn Gigg

comment:3 Changed 6 years ago by Martyn Gigg

Add schema attributes to root tag in DNS definition

Refs #11463

Changeset: 2c918891490cac76a26921a6a23a3cfeed73bc3a

comment:4 Changed 6 years ago by Martyn Gigg

Update the IDF documentation to include xsd attributes

Refs #11463

Changeset: 7f81fee248f616adf65bd5ac23350e8b04ae1eb5

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #505.

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:7 Changed 6 years ago by Federico Montesino Pouzols

Just a small note that to be able to run the ValidateInstrument... and similar system tests you might need to install minixsv (see PR #501) if you don't have it.

comment:8 Changed 6 years ago by Dan Nixon

@FedeMPouzols I realised after wondering for a while why it kept skipping, an error message would have been useful on the import test.

I can't help but wonder if a setup tools meta package could be created similar to the Debian one for all the Python packages Mantid needs.

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #505 from mantidproject/11463_add_xsd_attrs_dns_idf

Add xsd attributes to DNS instrument definition

Full changeset: 7842657d8d619e550ee28b2724dc6ee6edf65c62

comment:10 Changed 6 years ago by Martyn Gigg

@DanNixon In theory a good idea. As with all of these things it usually ends up coming down to available time

comment:11 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12302

Note: See TracTickets for help on using tickets.