Ticket #11480 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

New Indirect absorption correction fixes

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez

Description (last modified by Dan Nixon) (diff)

Spencer has noted a few issues with the new corrections.

  • Flat - Container thickness not disabled if no can.
  • Cyl - again Container radius not disabled if no can
  • Flat - it used to fill in thickness2 (back) using input for thickness1 (front)
  • Any chance of Annulus option while we're at it?
  • Convert units of workspaces form ApplyCorr back to original units

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Priority changed from critical to major
  • Component changed from Framework to Indirect Inelastic
  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Disable can otpions when there is no can

Refs #11480

Changeset: 4aefc5947d506b77df11546a981db6c3aefe1670

comment:4 Changed 6 years ago by Dan Nixon

Set back thickness with front

Refs #11480

Changeset: 4159f14f98ff519784bf34f6815f689e48368129

comment:5 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:6 Changed 6 years ago by Dan Nixon

Added annulus option

Refs #11480

Changeset: d83ee06a0024156389a208e0c4cf48ad37d86235

comment:7 Changed 6 years ago by Dan Nixon

Convert apply cor results back to sample WS units

Refs #11480

Changeset: 825a8e4d14f4e0a62a4f3d826a828ce86a89d8d5

comment:8 Changed 6 years ago by Dan Nixon

Stop SplineInterpolation overwriting the vertical axis

Refs #11480

Changeset: 39db00cacd37ee42f6d8d38d33b49716171675e1

comment:9 Changed 6 years ago by Dan Nixon

Support time bin plots and add to calc corr

Refs #11480

Changeset: 72d2fa7ed1ec93020204be67df2ff0342633f9e8

comment:10 Changed 6 years ago by Dan Nixon

COnvert output correction factors to Q

Refs #11480

Changeset: 63d756a60fc858f4da5a5d0b2641860287ba9bf9

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #527.

comment:12 Changed 6 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:13 Changed 6 years ago by Dan Nixon

I think I was a bit vague on the annulus option: the CylinderPaalmanPingsCorrection algorithm technically calculated for an annulus (as it takes an inner sample radius), the new annulus option is actually just the old cylinder option, the new cylinder option just has the sample inner radius fixed to 0.

comment:14 Changed 6 years ago by Dan Nixon

There are also a couple extra things that need to be done yet.

comment:15 Changed 6 years ago by Raquel Alvarez

Ok, just let me know when it is ready to test.

comment:16 Changed 6 years ago by Dan Nixon

Give annular corrections unique naming

Refs #11480

Changeset: 6cb0df02400a6dd724a125e5e7edd8b6fd8cea10

comment:17 Changed 6 years ago by Dan Nixon

Should be good now, the extra things added are the last two bullet points in the description.

comment:18 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11480_indirect_abs_cor_fixes

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/Indirect/IndirectTab.h

Refs #11480

Changeset: 53b3d4271fec6fd6492d879bf6503db57da740e5

comment:19 Changed 6 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #527 from mantidproject/11480_indirect_abs_cor_fixes

Indirect Calculate and Apply corrections fixes

Full changeset: 0d4ab5b74754157d332265085ca8d6ccfd8f404e

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12319

Note: See TracTickets for help on using tickets.