Ticket #11497 (closed: fixed)
Valgrind: Remove algorithm dependencies from DataObjectsTest
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Dan Nixon |
Description
The job is currently failing because DataObjectsTest cannot be run in isolation without MDAlgorithms.
Change History
comment:2 Changed 6 years ago by Martyn Gigg
Remove dependency on MDAlgorithms from MDEventInserter
Refs #11497
Changeset: 866afbc6eb9810a380d35555af2ef2a1c45a2efc
comment:3 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #539.
comment:4 Changed 6 years ago by Martyn Gigg
Remove FrameworkManager calls from DataObjects tests.
Refs #11497
Changeset: 1bea4360562e78c4c5e7334b75dac0b0cb08bfa1
comment:5 Changed 6 years ago by Martyn Gigg
Fix CheckWorkspacesMatch test
If the FrameworkManager is not loaded then CompareMDWorkspaces is not available and the check events tests fail. Refs #11497
Changeset: 1232636c72b16e7717ca266b38706d4b619edd37
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:7 Changed 6 years ago by Martyn Gigg
Use FakeMD helper in MDEventsTestHelper instead of algorithm
Refs #11497
Changeset: d3b8438a25456a06ea1fea812811981c03dfb9da
comment:8 Changed 6 years ago by Martyn Gigg
Remove dependency on MDAlgorithms from MDEventInserter
Refs #11497
Changeset: 866afbc6eb9810a380d35555af2ef2a1c45a2efc
comment:9 Changed 6 years ago by Martyn Gigg
Remove FrameworkManager calls from DataObjects tests.
Refs #11497
Changeset: 1bea4360562e78c4c5e7334b75dac0b0cb08bfa1
comment:10 Changed 6 years ago by Martyn Gigg
Fix CheckWorkspacesMatch test
If the FrameworkManager is not loaded then CompareMDWorkspaces is not available and the check events tests fail. Refs #11497
Changeset: 1232636c72b16e7717ca266b38706d4b619edd37
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge pull request #539 from mantidproject/11497_rm_mdalgorithms_dependencies_from_dataobjects
Remove MDAlgorithm dependencies from DataObjectsTest
Full changeset: 7763ccac0bc1b393b47f0a0391485bc6d4e26793
comment:12 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12335
Use FakeMD helper in MDEventsTestHelper instead of algorithm
Refs #11497
Changeset: d3b8438a25456a06ea1fea812811981c03dfb9da