Ticket #11505 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve LoadNexusProcessed performance on multiperiod workspaces

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

This ticket fixes an issue found while investigating #11483

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 6 years ago by Harry Jeffery

Refs #11505 Use openLocal when possible

openLocal performs far better than open, and we're able to use it when loading multidimensional data sets in LoadNexusesProcessed, so let's.

Changeset: 408db3be33988b098b8087d7ba95c3cd6e59f1db

comment:3 Changed 5 years ago by Harry Jeffery

  • Summary changed from Improve LoadNexusProcessed performance on multidimensional workspaces to Improve LoadNexusProcessed performance on multiperiod workspaces

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #560.

comment:5 Changed 5 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 5 years ago by Owen Arnold

Could you please add some comments around the code relating to the fix. Although I understand what's been done here, it would be good if others had that opportunity too.

comment:7 Changed 5 years ago by Harry Jeffery

Refs #11505 Annotate optimisations

Changeset: bddad684f4eecfd069fed8f2fa47aaeeab551ac0

comment:8 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #560 from mantidproject/11505_improve_loadnexusproc_performance

Optimise LoadNexusProcessed for multiperiod data

Full changeset: 21854ca80ef2b5470c01d7c679157f2a4a03af5f

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12343

Note: See TracTickets for help on using tickets.