Ticket #11512 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fix valgrind warnings in DataObjects & API

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The recent merge of MDEvents to DataObjects has highlighted some memory leaks we should take care of - ​http://builds.mantidproject.org/view/Valgrind/job/valgrind_core_packages/377/valgrindResult/

Change History

comment:1 Changed 5 years ago by Martyn Gigg

  • Status changed from new to inprogress

Fix memory leak in BoxController.

Poco::NodeList objects should always be used with Poco::AutoPtr. Refs #11512

Changeset: 34ada20eb40d5b46c5d9de1d624203136d24d725

comment:2 Changed 5 years ago by Martyn Gigg

Fix memory read error in MDHistoWorkspaceIterator & test

The skipping policy was being applied even if the iterator had reached the last element causing the skipping policy check to access an array out of bounds. Refs #11512

Changeset: 1ca499bac9146bd7f818ba74547fcd7287e3ecbb

comment:3 Changed 5 years ago by Martyn Gigg

Fix some of the valgrind issues for the MD objects.

Refs #11512

Changeset: 9ec88780376ba804a93b928456e4d75521657104

comment:4 Changed 5 years ago by Martyn Gigg

Clear more valgrind warnings from DataObjects.

Refs #11512

Changeset: 677c0c62575fee8b8c695e8aeb4fdfa2c34f1d3d

comment:5 Changed 5 years ago by Martyn Gigg

Clean memory leaks from CoordTransformAffine

Refs #11512

Changeset: d2e7482a33f7f6352a4643a8633efdc7a6ff1d99

comment:6 Changed 5 years ago by Martyn Gigg

Fix valgrind errors in MDBoxSaveable and tests.

Refs #11512

Changeset: 338323e697ce74c7d3a92bc4f65fdd6326282157

comment:7 Changed 5 years ago by Martyn Gigg

Fix more memory leaks in MD classes & tests.

Refs #11512

Changeset: f05603cb47aca2079391d43f07d235f7e9528050

comment:8 Changed 5 years ago by Martyn Gigg

Fix a fair few more valgrind warnings.

Refs #11512

Changeset: 9bdf246c87695971c8396e156b301bd865c08926

comment:9 Changed 5 years ago by Martyn Gigg

Several more valgrind warning fixes

Refs #11512

Changeset: cc45440c118b6042aefeffa928567b87db23de5e

comment:10 Changed 5 years ago by Martyn Gigg

Fix final set of reported valgrind warnings.

Refs #11512

Changeset: 4c1087c6de1992e1cd1b6e21850c752551ffd607

comment:11 Changed 5 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #588.

comment:11 Changed 5 years ago by Martyn Gigg

  • Status changed from inprogress to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 5 years ago by Martyn Gigg

Fix headers in MDLeanEvent.

Refs #11512

Changeset: ecb3bfc3d0feaac40ebe0401bb084d98b12d027c

comment:14 Changed 5 years ago by Martyn Gigg

Fix MDLeanEvent includes for gcc 4.4

Refs #11512

Changeset: 416b1a09a4ec10a9d71dc918b65d3a8c6ec2c938

comment:15 Changed 5 years ago by Martyn Gigg

Enable a test that was disabled by accident.

Refs #11512

Changeset: 91934c1a9ca26b99d7440d03f1d103377f819400

comment:16 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

comment:17 Changed 5 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:18 Changed 5 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #588 from mantidproject/11512_fix_memleaks_in_api_and_dataobjects

Fix valgrind memcheck warnings in DataObjects

Full changeset: ​93670b4cd29e332ae75bcdd6fb900b05ec932397

comment:19 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12350

Note: See TracTickets for help on using tickets.