Ticket #11538 (inprogress)

Opened 5 years ago

Last modified 5 years ago

Modify IMAT GUI to use remote algorithms v2 instead of SCARFTomoReconstruction

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Framework Keywords: IMAT
Cc: Blocked By: #11126
Blocking: Tester:

Description

There are TODO comments in the IMAT tomography GUI code that say what needs to be done: use remote algorithms with SCARF compute resource instead of the (transitional) SCARFTomoReconstruction algorithm. Just go ahead with those TODOs as soon as #11126 is merge into master. This is straightforward and just requires a bit of double-checking / testing.

Even though this is a modification in GUI code, I classify this as "Framework", as it is actually about using different algorithms and getting rid of a temporary one. The GUI functionality should remain unaffected.

The algorithm SCARFTomoReconstruction was introduced as a temporary solution, and after this it can go away. It could be removed as part of this ticket or in a follow-up ticket. In any case it would be good to kill it before 3.4.

Change History

comment:1 Changed 5 years ago by Federico M Pouzols

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 fix doxygen warning for backgroundprovider

Changeset: cf153222b23dbe7441a009ba399ef89737e06fc6

comment:3 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 Fix coverity issue in scale workspace

Changeset: 248f27051f87ec3f4e22d677ae3a0b72f9acf997

comment:4 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize initialview variable

Changeset: 49741c59ded8efbe85e8bec889c9012478612ea7

comment:5 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 fix uninitialized vars in splatterplotfactory

Changeset: 2382dc1b57eb6346bb8dacf2e8431f8aa35f8c8c

comment:6 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize logscale of colorscale struct

Changeset: bf52103326e884a29e9f8fec27fca759e181a850

comment:7 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize original table witdth in peakWidget

Changeset: e41d2fcd3f9af0b75fe1967c62decdacb834d2b0

comment:8 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize coordinateSystem in peaksTableController

Changeset: b4a90609cd8b1bd4fc1d3b000b709af006e5bbca

comment:9 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 pass view frustum as shared pointer

Changeset: 04953228f084d23d02dd21dbf62fd77c2dba9ec5

comment:10 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 Solve merge issue

Changeset: 6ea95b75b8055a6892f1424c2e73e611860d2243

comment:11 Changed 5 years ago by Anton Piccardo-Selg

Comments 1 to Comments 10 refer to ticket 11583. Sorry.

comment:12 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #608.

comment:13 Changed 5 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:14 Changed 5 years ago by Anton Piccardo-Selg

Renaming of pull request is required

comment:15 Changed 5 years ago by Federico M Pouzols

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:16 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from reopened to inprogress

Refs #11538 fix doxygen warning for backgroundprovider

Changeset: cf153222b23dbe7441a009ba399ef89737e06fc6

comment:17 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 Fix coverity issue in scale workspace

Changeset: 248f27051f87ec3f4e22d677ae3a0b72f9acf997

comment:18 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize initialview variable

Changeset: 49741c59ded8efbe85e8bec889c9012478612ea7

comment:19 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 fix uninitialized vars in splatterplotfactory

Changeset: 2382dc1b57eb6346bb8dacf2e8431f8aa35f8c8c

comment:20 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize logscale of colorscale struct

Changeset: bf52103326e884a29e9f8fec27fca759e181a850

comment:21 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize original table witdth in peakWidget

Changeset: e41d2fcd3f9af0b75fe1967c62decdacb834d2b0

comment:22 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 initialize coordinateSystem in peaksTableController

Changeset: b4a90609cd8b1bd4fc1d3b000b709af006e5bbca

comment:23 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 pass view frustum as shared pointer

Changeset: 04953228f084d23d02dd21dbf62fd77c2dba9ec5

comment:24 Changed 5 years ago by Anton Piccardo-Selg

Refs #11538 Solve merge issue

Changeset: 6ea95b75b8055a6892f1424c2e73e611860d2243

comment:25 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:26 Changed 5 years ago by Federico M Pouzols

  • Keywords IMAT added

comment:27 Changed 5 years ago by Federico Montesino Pouzols

add CommandLine output prop from QueryJob, re #11538

Changeset: beb472f5c64fd52994a6dfe0d907c7772d33b40d

comment:28 Changed 5 years ago by Federico Montesino Pouzols

fill in command line, use g_ for static members, re #11538

Changeset: 59601f6779cbe7d9d2507339607153d0f97a65bb

comment:29 Changed 5 years ago by Federico Montesino Pouzols

use new remote algorithms to login, submit, query status, re #11538

Changeset: 576d35749a70af74773270f190167b1b0ce7a821

comment:30 Changed 5 years ago by Federico Montesino Pouzols

use remote algorithm v2 to cancel/abort jobs, re #11538

Changeset: deb52d35e2b5d4b4575db455c17494aab0d76b53

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12376

Note: See TracTickets for help on using tickets.