Ticket #11550 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Incorrect data layout with LoadNexusMonitors with multiperiod ISIS event files

Reported by: Martyn Gigg Owned by: Nick Draper
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

An example is run 2809 from LARMOR. There are 4 periods in the file but loading the monitors causes a single period to be loaded with 4 times the number of time channels.

Change History

comment:1 Changed 5 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Martyn Gigg to Nick Draper
  • Priority changed from major to critical

comment:2 Changed 5 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #11550 LoadEventMonitors now able to handle period for histograms

Changeset: c0a0c017fac7633c0d0beed2b67b901fcbf8c01d

comment:3 Changed 5 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 5 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 5 years ago by Nick Draper

re #11550 Fix for DGSReduction

Changeset: 85a177bf70b410cdf1e52750759411d375fffd4e

comment:7 Changed 5 years ago by Nick Draper

re #11550 Fix for EQSANSLoad

Changeset: 2e3ee850fa29615ee7d005bcc50241b933927602

comment:8 Changed 5 years ago by Nick Draper

re #11550 Fix for EQSANSLoad

Changeset: b0bbb4e3687fb3c2ef83d56b843f44a0631aafd4

comment:9 Changed 5 years ago by Nick Draper

re #11550 better error message for EQSANSLoad

Changeset: 4afe5fad9dd2ee88b585d34b75bb7769366171fb

comment:10 Changed 5 years ago by Martyn Gigg

This all seems to work as intended from a user's perspective.

comment:11 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #587 from mantidproject/feature/11550_larmor_monitors_with_periods

LoadEventMonitors now able to handle period for histograms

Full changeset: ​b3abf4f1b410d5fdc51afec010f1baac36e8f9ac

comment:12 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12388

Note: See TracTickets for help on using tickets.