Ticket #11562 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Load Instrument segfaults if called from GUI

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Alex Buts) (diff)

Try the operations 

Load(Filename=r'D:\Data\MantidDevArea\Datastore\DataCopies\Testing\Data\DocTest\MAR11001.raw', OutputWorkspace='MAR11001')
LoadInstrument(Workspace='MAR11001', Filename=r'c:\Mantid\Code\Mantid\instrument\MARI_Definition.xml')

but execute LoadInstrument from GUI. Mantid segfaults on LoadInstrument

Change History

comment:1 Changed 5 years ago by Alex Buts

  • Status changed from new to inprogress

Re #11562 This should fix the issue

Changeset: 4d429faf97b648b8e109e7711265847e549d6979

comment:2 Changed 5 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 5 years ago by Alex Buts

Its fixed as ​https://github.com/mantidproject/mantid/pull/592.

To reproduce crash deselect RewriteSpectraMap property. Observed on Windows and on some Ubuntu machines.

It become clear after discussion with Martyn, that the issue is within custom LoadInstrument dialogue and the best way of dealing with this is just removing this dialogue,as standard one now have number of nice features, missing in custom, plus the bug there.

MAR11001.raw file should be present either in unit tests or Doctests. After the fix Manid does not crashes any more on LoadInstrument.

Last edited 5 years ago by Alex Buts (previous) (diff)

comment:4 Changed 5 years ago by Andrei Savici

  • Status changed from inprogress to verifying
  • Tester set to Andrei Savici

comment:5 Changed 5 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #592 from mantidproject/11562_SegfaultOnLoadInstrumentDialog

Fixing LoadInstrumentDialog segfault

Full changeset: ​7b158106f648c3a3804bba1ae197f0251329c2a1

comment:6 Changed 5 years ago by Nick Draper

  • Resolution set to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:7 Changed 5 years ago by Alex Buts

Merge branch '11562_SegfaultOnLoadInstrumentDialog' into 11508_ParamWithHelpString

Full changeset: ​9cfdbd112150f2a85512d062cb7ea4db1b3cd4cb

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12400

Note: See TracTickets for help on using tickets.