Ticket #11574 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

FindNeighbours performance

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Harry Jeffery) (diff)

This commit ​https://github.com/mantidproject/mantid/commit/046b37f2984784417c4b44b7139416bb8e846568

caused a 25% increase in run time. See attachment.

Attachments

Screen Shot 2015-04-16 at 12.29.09.png​ (43.0 KB) - added by Owen Arnold 5 years ago.
new_findNeighbours_perf_graph.png​ (45.8 KB) - added by Harry Jeffery 5 years ago.
The performance now

Change History

Changed 5 years ago by Owen Arnold

comment:1 Changed 5 years ago by Owen Arnold

  • Priority changed from major to critical
  • Status changed from new to assigned
  • Owner changed from Owen Arnold to Harry Jeffery

Realistically, I'm not going to have time to work on this, but I don't want it to slip off the radar because it's quite an important feature. The compound effect of loss of performance will be significant as the number of dimensions increases.

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11574 Preallocate the neighbour indices vector

Changeset: 33b61d6136855d2acb5e7ef19a0770d236750da6

comment:4 Changed 5 years ago by Harry Jeffery

Refs #11574 Optimise isNeighbourOfSubject

Changeset: 4441d127943a9d2e85ee22e40b9231a328b915df

comment:5 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verifying
  • Tester set to Owen Arnold

comment:6 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #620.

comment:7 Changed 5 years ago by Harry Jeffery

  • Milestone changed from Release 3.5 to Release 3.4

comment:8 Changed 5 years ago by Harry Jeffery

  • Description modified (diff)

comment:9 Changed 5 years ago by Owen Arnold

  • Status changed from verify to closed

Merge pull request #620 from mantidproject/11574_optimise_findneighbours

Optimise findNeighbours

Full changeset: ​aafc79279062988a669b78dd483a1db72505bdf8

Changed 5 years ago by Harry Jeffery

The performance now

comment:10 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12412

Note: See TracTickets for help on using tickets.