Filters are not removed when switching to Splatterplot

[Anton Piccardo-Selg]

Filters are not removed (scale and cut) when switching to splatterplot. The cut filter causes a crash.

[Anton Piccardo-Selg]

The scale filter was never removed, even in previous versions. This works fine.

The cut filter is removed but the underlying source is not made the active source which then is a problem when swithcing to Splatterplot mode, as this relies on an active source.

[Anton Piccardo-Selg]

Refs #11602 Fixed deletion of sources

Changeset: cc14ffe8fd4f9f511c320685f3a228eabed8cafd

[Anton Piccardo-Selg]

Refs #11602 Change log level for initial view

Changeset: 5d6f97a90aa63de2ec35d00e29c1feecc1ee2a5d

[Anton Piccardo-Selg]

This is being verified as ​pull request #628.

[Federico Montesino Pouzols]

This also works well. It doesn't crash and behaves well. I'll wait for the windoze build to double-check but I think there shouln't be any issues there.

[Federico Montesino Pouzols]

Oops, but if you add the following two steps after step 5, you'll get a crash. This looks unrelated to the ticket this PR addresses, and has more to do with the "pick mode". Staying in the Splatterplot view:

• Click on Override PC
• Click on "Pick Mode"

After this you'll get a segfault. An small white cross appears in the center of the view but before you can do anything it crashes. This is the trace that I could get: ` #0 0x00007fffc5a77b30 in pqProxy::getProxy() const () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqCore-pv4.3.so.1 #1 0x00007fffc5a85751 in pqScalarsToColors::getScalarRange() const () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqCore-pv4.3.so.1 #2 0x00007fffc6e5130f in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::setMinBufferAndMaxBuffer(pqPipelineSource*, double&, double&) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #3 0x00007fffc6e51967 in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::getStandardColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #4 0x00007fffc6e51b98 in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::getColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #5 0x00007fffc6e57d75 in Mantid::Vates::SimpleGui::ColorUpdater::autoScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #6 0x00007fffc6e86ea4 in Mantid::Vates::SimpleGui::ViewBase::setAutoColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #7 0x00007fffc6e59993 in Mantid::Vates::SimpleGui::MdViewerWidget::checkForUpdates() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #8 0x00007fffc6e8a155 in Mantid::Vates::SimpleGui::MdViewerWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #9 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #10 0x00007fffc665dd9a in pqPropertiesPanel::apply() () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqComponents-pv4.3.so.1 #11 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #12 0x00007fffc6e81698 in Mantid::Vates::SimpleGui::SplatterPlotView::onPickModeToggled(bool) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #13 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #14 0x00007ffff4d62c32 in QAbstractButton::toggled(bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #15 0x00007ffff4aa482d in QAbstractButton::setChecked(bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #16 0x00007ffff4aa43e3 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #17 0x00007ffff4aa4534 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 `

I'm not sure if there's any ticket about this? If not maybe we need to open one for this. Well, actually you just need to open a workspace, switch to the "scatterplot view", and click "pick mode". You'll get a very similar crash, like this: ` #0 0x00007fffc5a77b30 in pqProxy::getProxy() const () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqCore-pv4.3.so.1 #1 0x00007fffc5a85751 in pqScalarsToColors::getScalarRange() const () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqCore-pv4.3.so.1 #2 0x00007fffc6e5130f in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::setMinBufferAndMaxBuffer(pqPipelineSource*, double&, double&) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #3 0x00007fffc6e51967 in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::getStandardColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #4 0x00007fffc6e51b98 in Mantid::Vates::SimpleGui::AutoScaleRangeGenerator::getColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #5 0x00007fffc6e57d75 in Mantid::Vates::SimpleGui::ColorUpdater::autoScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #6 0x00007fffc6e86ea4 in Mantid::Vates::SimpleGui::ViewBase::setAutoColorScale() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #7 0x00007fffc6e59993 in Mantid::Vates::SimpleGui::MdViewerWidget::checkForUpdates() () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #8 0x00007fffc6e8a155 in Mantid::Vates::SimpleGui::MdViewerWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #9 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #10 0x00007fffc665dd9a in pqPropertiesPanel::apply() () from /home/fedemp/build-mantidnightly/build-paraview/lib/libvtkpqComponents-pv4.3.so.1 #11 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #12 0x00007fffc6e81698 in Mantid::Vates::SimpleGui::SplatterPlotView::onPickModeToggled(bool) () from /home/fedemp/test/build-mantid/binlibMantidVatesSimpleGuiViewWidgets.so #13 0x00007ffff39def4c in QMetaObject::activate(QObject*, QMetaObject const*, int, void) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4 #14 0x00007ffff4d62c32 in QAbstractButton::toggled(bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 #15 0x00007ffff4aa482d in QAbstractButton::setChecked(bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4 ` It seems to happen with other Histo and Event workspaces. So it looks like there's something wrong in "pick mode".

[Anton Piccardo-Selg]

Refs #11602 Fix lookuptable issue

Changeset: eb95f4ea3f066d42235e3d85849e0b4b8fbf856e

[Federico Montesino Pouzols]

Yes, the last commit fixed this last crash issue for me.

[Federico Montesino Pouzols]

All is well. This PR closes the ticket issue + the "pick mode" issue.

[Federico Montesino Pouzols]

Merge pull request #628 from mantidproject/feature/11602_remove_cut_filter_when_switching

Bugfix for removing cut filter when switching to splatterplot

Full changeset: ​644358cad8fb888fb8d9129fcb0352aef80c8a62

[Stuart Campbell]

This ticket has been transferred to github issue ​12440