Ticket #11616 (inprogress)

Opened 5 years ago

Last modified 5 years ago

Make POLDI algorithms more robust against input errors

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.5
Component: Framework Keywords: POLDI, bugfix
Cc: Blocked By:
Blocking: #10702 Tester:

Description

There are some small problems in Problems in PoldiFitPeaks1D and PoldiFitPeaks2D that I would like to address before finishing the workflow algorithm for POLDI.

  1. PoldiFitPeaks2D and PoldiAnalyseResiduals (and thus also PoldiAutoCorrelation) can only work with 2D workspaces that have a POLDI instrument set, otherwise unpredictable things happen. This can be validated before the algorithm is run at all and should avoid random crashes.
  1. PoldiFitPeaks1D should use EstimatePeakErrors just like PoldiFitPeaks2D. Furthermore it should check that parameters are reasonable (q-Values above zero for example).

Change History

comment:1 Changed 5 years ago by Michael Wedel

  • Status changed from new to inprogress

Refs #11616. More strict criteria for acceptable peaks

Changeset: 5604de2aca7204f57db57e16d1856cb88bdb3501

comment:2 Changed 5 years ago by Michael Wedel

  • Milestone changed from Release 3.4 to Release 3.5

comment:3 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12454

Note: See TracTickets for help on using tickets.