Ticket #11619 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Create an algorithm crop a workspace based on a mask.

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: pascal.manuel@… Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

The algorithm should take a workspace and a mask and output a workspace with unmasked spectra only.

Change History

comment:1 Changed 5 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #11619. Added the new algorithm.

Changeset: 10bf85d9a2d0643698744488f62461e2804ee62b

comment:2 Changed 5 years ago by Roman Tolchenov

Re #11619. Renamed and moved the algorithm.

Changeset: fe26fe14558a210cd4ee5cf0c2ceb4bea629e87b

comment:3 Changed 5 years ago by Roman Tolchenov

Re #11619. Copy spectra from a histo workspace.

Changeset: 101f2a27f5f0b782061f2b25bedac48d0607e5bf

comment:4 Changed 5 years ago by Roman Tolchenov

Re #11619. Added ExtractSpectra algorithm.

Changeset: 197abe39e6c792f216bb9d79c67db6c01d623a0d

comment:5 Changed 5 years ago by Roman Tolchenov

Re #11619. Changed CropWorkspace to use ExtractSpectra.

Changeset: cfd94843a96058e28117ab76290f2df363df7524

comment:6 Changed 5 years ago by Roman Tolchenov

Re #11619. RemoveMaskedSpectra and CropWorkspace use ExtractSpectra.

Changeset: 2e0326db7263a2722aeddc6246486e0bb85f0449

comment:7 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:8 Changed 5 years ago by Roman Tolchenov

Re #11619. Unit test for ExtractSpectra.

Changeset: 0bd19934a9a84b243993ab6a501d2458caa38350

comment:9 Changed 5 years ago by Roman Tolchenov

Re #11619. Added a test for a ragged histo workspace.

Changeset: d1c68f9d26c1bcd9dfa281b9aa56c027a482d7b1

comment:10 Changed 5 years ago by Roman Tolchenov

Re #11619. ExtractSpectra doc file.

Changeset: 5559948a2517988f840bf5ff8ab13bc195695e76

comment:11 Changed 5 years ago by Roman Tolchenov

Re #11619. Unit test for RemoveMaskedSpectra.

Changeset: 14f5ccf1950af0cc9a7d07fe3fc0495c8ba37d0d

comment:12 Changed 5 years ago by Roman Tolchenov

Re #11619. Doc file for RemoveMaskedSpectra algorithm.

Changeset: 64f8c1762f345e247d4c846e268ab422adb24c1b

comment:13 Changed 5 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #678.

comment:14 Changed 5 years ago by Roman Tolchenov

Re #11619. Fix compiler warnings.

Changeset: 8554918b02e6c244bb8f933eae14961bb9c0081a

comment:15 Changed 5 years ago by Roman Tolchenov

Re #11619. Fix another compiler warning.

Changeset: bcf25366db9829f1fa6442835daa38a518af4c9e

comment:16 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:17 Changed 5 years ago by Federico Montesino Pouzols

I was testing this and everything seemed ok. But we have got some merge conflict this morning. Could you take a look? I'd then double-check again and merge it.

comment:18 Changed 5 years ago by Roman Tolchenov

Merge branch 'master' into 11619_crop_by_mask

Conflicts:

Code/Mantid/Framework/Algorithms/src/CropWorkspace.cpp

Re #11619.

Changeset: 349d1bd6b627e0c47c29089cb4805b80f8d5832d

comment:19 Changed 5 years ago by Federico Montesino Pouzols

This looks fine. The algorithms are well tested and everything seems to work as expected. Interactive use with the instrument viewer works very nicely. I'm just waiting for the system and doc tests to finish, but I think this is ready to be merged in. I just put a comment for a couple of typos, let me know if you want to fix those before I merge this branch. These typos don't need CI builds again.

comment:20 Changed 5 years ago by Roman Tolchenov

I want to fix the dynamic_cast thing. It will start full rebuild.

comment:21 Changed 5 years ago by Roman Tolchenov

Re #11619. Cleaner dynamic cast checks. Couple of typos.

Changeset: 3f90d28748b6b396e7f1bc44fc7384b5eb7511fd

comment:22 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #678 from mantidproject/11619_crop_by_mask

RemoveMaskedSpectra algorithm.

Full changeset: ​330b2abc60e9c91801de5901d20961a61f7cafd4

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12457

Note: See TracTickets for help on using tickets.