Ticket #11626 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Use IntegrateMDHistoWorkspace as a mode in the LineViewer

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.5
Component: Direct Inelastic Keywords:
Cc: Blocked By: #11633, #11641
Blocking: #11648 Tester: Federico Montesino Pouzols

Description

  • This draws on the new integration algorithm [IntegrateMDHistoWorkspace] which soon will be executed as a mode by CutMD (#11572)

The idea here is quite simple: If you are performing a line cut in the LineViewer, if you are slicing a MDHistoWorkspace in an axis-aligned fashion use IntegrateMDHistoWorkspace rather than BinMD to generate the output MDHistoWorkspace.

Change History

comment:1 Changed 5 years ago by Owen Arnold

CutMD should replace the option to use BinMD or IntegrateMDHistoWorkspace in the future as a super algorithm. For this iteration we will not try to do that, the reason we won't do that for this release is that few users are yet using CutMD and might be surprised to see it in the history. A second reason is that CutMD strips out original workspaces and transfomation information where as BinMD does not, I haven't yet though through all the issues relating to this and whether there would be any undesirable effects for our users.

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11626 Begin adding support for IntegrateMDHistoWorkspace

Changeset: 85c45cb3858b831029a4294129748e5bb13e6c1a

comment:4 Changed 5 years ago by Owen Arnold

  • Blocked By 11633 added

comment:5 Changed 5 years ago by Harry Jeffery

  • Milestone changed from Release 3.4 to Release 3.5

comment:6 Changed 5 years ago by Harry Jeffery

Refs #11626 Use existing bin widths if able

Changeset: 9c0f64e9cbcfaa3926f2c730b84f94e42d82a3ef

comment:7 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #655.

comment:8 Changed 5 years ago by Harry Jeffery

  • Blocked By 11641 added

comment:9 Changed 5 years ago by Harry Jeffery

  • Blocking 11648 added

comment:10 Changed 5 years ago by Harry Jeffery

Refs #11626 Correctly handle perpendicular axis

Changeset: 6ad28a8a3a9d9fe750eb228fa2be72aeb8ce0637

comment:11 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:12 Changed 5 years ago by Federico Montesino Pouzols

Works well for me, as long as you keep your cut aligned with shift+ it will run IntegrateMDHistoWorkspace and produce sensible results.

Maybe this detail could be added in the wiki page of the Slice Viewer? I'm not sure if users need/want to know what algorithms are running, and anyway it is logged.

comment:13 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #655 from mantidproject/11626_use_integratemdhistoworkspace_in_lineviewer

Use IntegrateMDHistoWorkspace in lineviewer when able

Full changeset: 6330a3ef2bb1aaedb2e8264e26f7973237ed2eb0

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12464

Note: See TracTickets for help on using tickets.