Ticket #11638 (closed: fixed)
Clean (OS)IRIS and IN16B parameter files
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Roman Tolchenov |
Description
Currently there is a parameter efixed-val attached to the instrument and Efixed attached to the analyser, they are the same values so efixed-val should be removed.
The only time I think it is read is in the IDR ET interface for (OS)IRIS, here Efixed should be read instead.
Change History
comment:5 Changed 5 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #658.
comment:7 Changed 5 years ago by Dan Nixon
Fix failing tests Refs #11638
Changeset: 50e3a4038b1699a1948b1f0718df790d1ef45c83
comment:9 Changed 5 years ago by Dan Nixon
Merge branch 'master' into 11638_clean_efixed_parameters
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSqw.cpp
Refs #11638
Changeset: ed5f3e684a4d75644d20a24d8170a0b242c1e5cb
comment:11 Changed 5 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:12 Changed 5 years ago by Roman Tolchenov
Which release is it?
comment:13 Changed 5 years ago by Dan Nixon
3.4 now as if it was left to 3.5 this would break UIs as the IPFs would be out of sync with the code.
comment:14 Changed 5 years ago by Dan Nixon
comment:15 Changed 5 years ago by Dan Nixon
comment:16 Changed 5 years ago by Dan Nixon
comment:17 Changed 5 years ago by Dan Nixon
comment:18 Changed 5 years ago by Dan Nixon
Fix failing tests Refs #11638
Changeset: 50e3a4038b1699a1948b1f0718df790d1ef45c83
comment:19 Changed 5 years ago by Dan Nixon
comment:20 Changed 5 years ago by Dan Nixon
Merge branch 'master' into 11638_clean_efixed_parameters
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSqw.cpp
Refs #11638
Changeset: ed5f3e684a4d75644d20a24d8170a0b242c1e5cb
comment:21 Changed 5 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge pull request #658 from mantidproject/11638_clean_efixed_parameters
Clean efixed parameters in indirect IPFs
Full changeset: 5e3ce448daa55201a8b7d3aafd3612872c64248f
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12476