Ticket #11640 (closed: fixed)
IDR SQw is broken by the change of algorithm names
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Federico Montesino Pouzols |
Description
The SofQW algorithms have been renamed and this has broken this UI.
Change History
comment:2 Changed 5 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #659.
comment:3 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:4 Changed 5 years ago by Federico Montesino Pouzols
Works well. In the algorithm history I can see SofQWPolygon and SofQWNormalisedPolygon.
To see it in the logs you need to go to debug level, I think, which is extremely verbose. Maybe an information/notice log message could be added about this? Not sure if that's common or recommended in workflow algorithms, but it could be helpful to users.
I just noticed an extremenly minor thing: the tab order of the E binning values seems a bit disordered.
comment:5 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #659 from mantidproject/11640_fix_idr_sqw
Use the new SofQW workflow algorithm in IDR tab
Full changeset: 694558e05ccde461f5d8cdf3e60582ec01cfbd03
Use the new SofQW workflow algorithm
Refs #11640
Changeset: 81b44d901aa73fc54816744e28647ae88838105b