Ticket #11650 (closed: fixed)
Put bin width as an attribute in DKT fitting function
Reported by: | Raquel Alvarez Banos | Owned by: | Raquel Alvarez Banos |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.4 |
Component: | Muon | Keywords: | Muon |
Cc: | Blocked By: | ||
Blocking: | Tester: | Federico Montesino Pouzols |
Description
Bin width should be an attribute as scientists often need to use different values depending on the dataset.
Change History
comment:2 Changed 5 years ago by Raquel Alvarez Banos
- Status changed from new to inprogress
Re #11650 Add eps attribute
Changeset: 925025e0d4f75076bfaa304bfa195ab3f15444d6
comment:3 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Minor changes
Changeset: 3b69409130c148bef87fc560ff77d99c830325c1
comment:4 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Set a minimum value for eps
Changeset: c9c7024715e62155f2237308bd89656d1a4d2d74
comment:5 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Check if eps changed, if so, we need to re-do calculations
Changeset: 17ec5e821c45e9413beb7c88e667c541f2866d03
comment:6 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Set maximum eps value
Changeset: 2bd0dc1a1824445797cb6709b9f8e9a79e3edae3
comment:7 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Rename attribute
Changeset: 9154e2edb8dc128739d4b90a860add3ec3d87257
comment:8 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Remove parameter if BinWidth is not within limits
Changeset: b42b04850c011bd1b2410366be9f041a64beb403
comment:9 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Change maxEps and minEps
Changeset: 44770d694293c971666ca23ac44f755b864c7f95
comment:10 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Change error messages
Changeset: e122b852aab6a1f5ea952aec9ba4ae4f997359cb
comment:11 Changed 5 years ago by Raquel Alvarez
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #682.
comment:12 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:13 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Non-zero field is implemented, remove outdated note
Changeset: 55c5d24309a14b90871ab6163771343a7eb4e5f5
comment:14 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Add note about new attribute in the documentation
Changeset: 0700688e089e01549774437c20c68e1fda689344
comment:15 Changed 5 years ago by Federico Montesino Pouzols
It works well and shows an informative message.
comment:16 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Add eps attribute
Changeset: 925025e0d4f75076bfaa304bfa195ab3f15444d6
comment:17 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Minor changes
Changeset: 3b69409130c148bef87fc560ff77d99c830325c1
comment:18 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Set a minimum value for eps
Changeset: c9c7024715e62155f2237308bd89656d1a4d2d74
comment:19 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Check if eps changed, if so, we need to re-do calculations
Changeset: 17ec5e821c45e9413beb7c88e667c541f2866d03
comment:20 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Set maximum eps value
Changeset: 2bd0dc1a1824445797cb6709b9f8e9a79e3edae3
comment:21 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Rename attribute
Changeset: 9154e2edb8dc128739d4b90a860add3ec3d87257
comment:22 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Remove parameter if BinWidth is not within limits
Changeset: b42b04850c011bd1b2410366be9f041a64beb403
comment:23 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Change maxEps and minEps
Changeset: 44770d694293c971666ca23ac44f755b864c7f95
comment:24 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Change error messages
Changeset: e122b852aab6a1f5ea952aec9ba4ae4f997359cb
comment:25 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Non-zero field is implemented, remove outdated note
Changeset: 55c5d24309a14b90871ab6163771343a7eb4e5f5
comment:26 Changed 5 years ago by Raquel Alvarez Banos
Re #11650 Add note about new attribute in the documentation
Changeset: 0700688e089e01549774437c20c68e1fda689344
comment:27 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #682 from mantidproject/11650_Put_bin_width_as_attribute
Show BinWidth as attribute in DKT
Full changeset: d697741b934992ae03b20247634cfdf7072bc52f
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12488
This ticket has been created after discussion with muon scientists today.