Ticket #11656 (reopened)

Opened 5 years ago

Last modified 5 years ago

History recording broken from within workflow algorithm

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description (last modified by Martyn Gigg) (diff)

As part of the SNSPowderReduction workflow there is a call to GeneratePythonScript to give a script of the commands used during the workflow. This is currently giving and empty script: 

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################

The script is fine if you run the algorithm and then generate the hisory afterwards

Change History

comment:1 Changed 5 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 5 years ago by Martyn Gigg

  • Status changed from new to inprogress

Attach the history to workspaces during workflow algorithms.

This enables GeneratePythonScript to be run as part of a workflow algorithm since the history up to that point has been recorded properly on the workspace and not just in the parent algorithm. Refs #11656

Changeset: a56301a1a6b15969451434438c0267078ba2492a

comment:3 Changed 5 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #680.

comment:4 Changed 5 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:5 Changed 5 years ago by Martyn Gigg

This is not the right way to got with this.

comment:6 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:7 Changed 5 years ago by Martyn Gigg

  • Priority changed from critical to major
  • Milestone changed from Release 3.4 to Release 3.5

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12494

Note: See TracTickets for help on using tickets.