Ticket #11673 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Bugfix: Use current color map when data when loading new data and the VSI is alreay open

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: GUI Keywords: VATES
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

When a data set is loaded into the VSI, the preferred color map is detected. This can be either of the last session, or a specific setting. When switching the views the current color map is used for the new view. When another color map is loaded, we currently load the preferred color map and not the current.

Attachments

MDEvent_Osiris.nxs​ (2.3 MB) - added by Anton Piccardo-Selg 5 years ago.

Change History

comment:1 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from new to inprogress

Refs #11673 Refactor the color map loading

Changeset: 655ed8145cae7bed6adbf508b6cd860a4bb94e25

comment:2 Changed 5 years ago by Anton Piccardo-Selg

Refs #11673 pick color map based on startup

Changeset: 780553c852c8efe013bbca281b53ff391f02a135

comment:3 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #697.

Changed 5 years ago by Anton Piccardo-Selg

comment:4 Changed 5 years ago by Anton Piccardo-Selg

  • Milestone changed from Backlog to Release 3.4

comment:5 Changed 5 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 5 years ago by Owen Arnold

Functionally fine, but pending some changes from a code review.

comment:7 Changed 5 years ago by Anton Piccardo-Selg

Changes from code review:

  1. changed naming of startup flag
  2. reduced color map logic
  3. made changes to the layout of the MDPlotting preferences tab

We should test the changes in the MDPlotting preferences tab.

Test of button logic

  1. Open the MDPlotting preferences tabs
  2. Go to the General tab and disable the "Use same default color map for Slice Viewer and VSI" checkbox (CB1).
  3. Go to the VSI tab and enable the "Use defaults for color map and background color" checkbox (CB2)
    • Confirm that the inputs for the default color map and the default background color are enabled.
  4. Disable CB2
    • Confirm that the inputs for the default color map and the default background color are disabled.
  5. Enable CB2 and go to the General tab and enable CB1.
    • Confirm that the input for the default color map is disabled and the default background color is enabled
  6. Disable CB1, enable CB2, close and restart the preferences window
    • Confirm that CB1 is disabled and CB2 is enabled
  7. Disable CB2 and enable CB1, close and restart the prefernces window
    • Confirm that CB2 is disabled and CB1 is enabled

comment:8 Changed 5 years ago by Anton Piccardo-Selg

Refs #11673 change prefernces layout

Changeset: 0f76b85551f5c128570b24039d4c76ce31a6f81d

comment:9 Changed 5 years ago by Anton Piccardo-Selg

Refs #11673 Refactoring of colormap logic in vsi

Changeset: 753c001b63006fab9bbeab20b4b073068abd3e74

comment:10 Changed 5 years ago by Anton Piccardo-Selg

Refs #11673 Changes to preferences window logic

Changeset: 59b32f7c3701a4c8393ca3fff133c416be7f48b8

comment:11 Changed 5 years ago by Anton Piccardo-Selg

Refs #11673 Refactor button logic for preferences

Changeset: 7e80b878e651bf49c4775aca63987915be07fa0f

comment:12 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #697 from mantidproject/feature/11673_fix_current_color_map_when_loading_new_source_in_vsi

Fix current color map when loading new source into an open instanec of the vsi

Full changeset: ​3c9c87e2b05aee1cc90ce2522701649bb8086a95

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12511

Note: See TracTickets for help on using tickets.