Context Navigation

← Previous Ticket
Next Ticket →

Ticket #11677 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fix: When removing the peaks filter the underlying splatterplot filter is not set to visible

Reported by:	Anton Piccardo-Selg	Owned by:	Anton Piccardo-Selg
Priority:	major	Milestone:	Release 3.4
Component:	Framework	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Owen Arnold

Description

This seems to be yet another integration issue. When the peaks table is being deleted, it does not change the visibility of the underlying splatterplot filter.

Attachments

MDEvent_Osiris.nxs (2.3 MB) - added by Anton Piccardo-Selg 5 years ago.
MDPeaks_NaCl_1.nxs (1.4 MB) - added by Anton Piccardo-Selg 5 years ago.

Change History

comment:1 Changed 5 years ago by Anton Piccardo-Selg

Status changed from new to inprogress

Refs #11677 fix the focus of the splatterplot

Changeset: 30b49de86250121276e1fb94e1b70032cbae3008

comment:2 Changed 5 years ago by Anton Piccardo-Selg

Refs #11677 Change deletion style

Changeset: 0824b8036a533c6bfe1a6db824a6f5d586d3943c

comment:3 Changed 5 years ago by Anton Piccardo-Selg

Refs #11677 delete peak sources according to new standard

Changeset: 43586268ded0eef9cb412a931251da0fd5cc03fa

comment:4 Changed 5 years ago by Anton Piccardo-Selg

Refs #11677 Refactor naming of internally rebinned workspaces

Changeset: 3d92d66c0298b05c4381fe2923148d17baca2620

comment:5 Changed 5 years ago by Anton Piccardo-Selg

Refs #11677 Hedge representation when changing color of peaks in vsi

Changeset: 4c34b2fb33c2b3b5b41e728dc258a0cb8ecd1f97

comment:6 Changed 5 years ago by Anton Piccardo-Selg

Refs #11677 Destroy peak filter correctly

Changeset: 4a86c2da8a02e91837c94550246cb86fb2ec2447

comment:7 Changed 5 years ago by Anton Piccardo-Selg

Status changed from inprogress to verify
Resolution set to fixed

This is being verified as pull request #717.

Changed 5 years ago by Anton Piccardo-Selg

Attachment MDEvent_Osiris.nxs added

Changed 5 years ago by Anton Piccardo-Selg

Attachment MDPeaks_NaCl_1.nxs added

comment:8 Changed 5 years ago by Owen Arnold

Status changed from verify to verifying
Tester set to Owen Arnold

comment:9 Changed 5 years ago by Owen Arnold

Also, if you set a background colour in the vsi (with the default background colour setting set in the Mantid preferences), and then drag and drop a peaks workspaces onto the VSI, the colour reverts back to the Mantid preferences version.

comment:10 Changed 5 years ago by Anton Piccardo-Selg

The identifier names of our plugins in splatterplot were moved to MdConstants
The suggested for the unsigned ints were implemented
The bug regarding the background color was fixed
An additional (old) crash bug was discovered and fixed

Parts 3 and 4 require additional testing

Testing Item 3

Ensure that you have enabled the checkbox "Use defaults for the color map and background color" in the preferences window.
Load the sample data set into the VSI, switch to standard view
Change the color map and the backgroudn color; make a note of them
Load the same workspace a second time (a distinct source is being created)
- Confirm that the color map and background color have not changed
Switch to the ThreeSlieView
- Confirm that the color map and background color have not changed
Close the VSI, but not Mantid and load the sample data set again into the VSI
- Confirm that the original color map and background color are loaded.

Testing Item 4

The crash occured when switching from standard view to splatterplot view without have an active source. This had not been hedged for in the SplatterPlotView's render method.

Load the sample data set into the VSI
Click on the builtin node of the pipelineBrowser
- Confirm that there is no active source, by checking that the properties panel does not contain useful information
Switch to the splatterplot view
- Confirm that Mantid does not crash
- Confirm that a warning is produced in the log.
Drag and drop a peaks workspace into the splatterplot view
- Confirm that Mantid does not crash
- Confirm that a warning is produced in the log.