Ticket #11679 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fix coverity and code issues in TomoReconstruction

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: minor Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

A few issues were found by coverity:

  • 1296290
  • 1296289
  • 1296288

At the same time a bit of minor code cleanup can be done.

Change History

comment:1 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from new to inprogress

fix coverity 1296290 + minor code cleanup, re #11679

Changeset: a6e8b1466b1489d472ab7d14e674e6436baf0e51

comment:2 Changed 5 years ago by Federico Montesino Pouzols

code cleanup, coverity 1296288, 1296289, re #11679

Changeset: 28ea9d160f3d760725ed38be7dd8531b9ab2a68a

comment:3 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #700.

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 5 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #700 from mantidproject/11679_fix_coverity_cod_issues_tomo

Fix coverity and code issues in TomoReconstruction

Full changeset: ​5ca4caf9ae45459e775b4801d4f5c6c767ec9dfa

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12517

Note: See TracTickets for help on using tickets.