Ticket #11683 (verify: fixed)

Opened 5 years ago

Last modified 5 years ago

ReflectometryReductionOne needs Integrated Monitor Switch

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.5
Component: Reflectometry Keywords: workflow
Cc: Blocked By:
Blocking: Tester:

Description

Look at ​http://docs.mantidproject.org/nightly/algorithms/ReflectometryReductionOne-v1.html. We force users to provide a I0MonitorIndex value.

  • Documentation should explain that this is a Workspace Index (do the same for other properties to distinguish properties that take Spectrum Number from Workspace Indexes.
  • Add a new boolean property called *NormalizeByIntegratedMonitor* which defaults to true. This preserves the current behaviour.
  • If this is false, take the monitor spectrum and rebin it between WavelengthMin and WavelengthMax and has the same step as the detector workspace. Divide through by this instead of the integrated workspace.
  • Update ReflectometryReductionOneAuto to reflect this, change and ensure that we can set it via the options on the new GUI.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Harry Jeffery

Refs #11683 Add NormalizeByIntegratedMonitors option

Changeset: 46e1d850df9acb67913bd174320a830af0ad52cc

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11683 Forward NormalizeByIntegratedMonitors in ReflRedOneAuto

Changeset: 98d1b176eb57e92200f35979d9296c04835b0a30

comment:4 Changed 5 years ago by Harry Jeffery

Refs #11683 Clarify that I0MonitorIndex is a workspace index

Changeset: 09de465ffca2a34e81653071c8286d01b6f01bd3

comment:5 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #710.

comment:6 Changed 5 years ago by Harry Jeffery

Note to self: Need to write unit test

comment:7 Changed 5 years ago by Harry Jeffery

Refs #11683 Don't do meaningless flat background correction

Changeset: a246f82fb47ac35498d9cb464fb2252120949292

comment:8 Changed 5 years ago by Harry Jeffery

Refs #11683 Test norm by int mon switch

Changeset: a378c45a6cbdeabeccdf9e3b7f7f59529b8b346a

comment:9 Changed 5 years ago by Harry Jeffery

Refs #11683 Don't calculate flat background for 1 bin

Changeset: b3492de01e45c279878312ce50e16d92875284ee

comment:10 Changed 5 years ago by Harry Jeffery

Refs #11683 Update documentation

Changeset: 82331fa36229d528956a12f802ef8c944cb0eb40

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12521

Note: See TracTickets for help on using tickets.