Ticket #11689 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

CanSAS loader doesn't load y-units

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.4
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

EQSANS instrument scientists noticed that the CanSAS loader doesn't load the units of the y-axis. The loader should read in the "unit" attribute of the Idata, which is an attribute required by the CanSAS format.

Change History

comment:1 Changed 5 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #11689 Read in y-axis units

Changeset: dd1aa6b6943fb7ba9a9f97f4a7324cc68f3bef27

comment:2 Changed 5 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #704.

comment:3 Changed 5 years ago by Mathieu Doucet

Re #11689 make output dir default more uniform across UI

Changeset: 4c593b2e587f2fcc0532f662ccd2d3137e0bb92f

comment:4 Changed 5 years ago by Mathieu Doucet

RE #11689 Fixing rst problem

Changeset: 8074e564543204258bfaeb88f9444f39c3d4478c

comment:5 Changed 5 years ago by Mathieu Doucet

  • Milestone changed from Release 3.5 to Release 3.4

comment:6 Changed 5 years ago by Mathieu Doucet

Re #11689 Add warning when theta = 0

Changeset: 994a50e6eef4bdd620efb4c6c27833cab01efc00

comment:7 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:8 Changed 5 years ago by Federico Montesino Pouzols

This fixes #11689(http://trac.mantidproject.org/mantid/ticket/11689).

Works well, after these changes the y units are shown if they are the same for all the data. Tested with the LOQ CanSAS file on debian.

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #704 from mantidproject/11689_cansas_y_units

CanSAS reader should read in y-axis units

Full changeset: e27fd9cf7404186b0ef4139c862a131ac8154081

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12527

Note: See TracTickets for help on using tickets.