Ticket #11692 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Script interpreter issue on OSX 10.9

Reported by: Owen Arnold Owned by: Steven Hahn
Priority: blocker Milestone: Release 3.4
Component: Python Keywords:
Cc: petersonpf@…, nick.draper@… Blocked By:
Blocking: Tester: Pete Peterson

Description (last modified by Owen Arnold) (diff)

From Jon Taylor 5th May 2015 to Mantid Help

Hi  
It seems the script interpreter has an issue
Thanks
Jon

In [8]: import numpy
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
TypeError: our_run_code() takes exactly 2 arguments (3 given)

In [9]: import numpy as np
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
TypeError: our_run_code() takes exactly 2 arguments (3 given)

In [10]: mtd.importAll()
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
TypeError: our_run_code() takes exactly 2 arguments (3 given)

I can confirm that, this is a real issue with the beta release.

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Description modified (diff)

comment:2 Changed 5 years ago by Steven Hahn

I was able to reproduce the issue after upgrading to ipython 3.1. import numpy worked fine with ipython 2.4.1 installed. It looks like run_code() changed in ipython3 to accept three instead of two arguments (see commit https://github.com/ipython/ipython/commit/0e76a04660a6c11e66b36b7e445e56ebbcd0bc5a ).

I'll try patching our_run_code() to accept three arguments and check if it can be make backwards-compatible.

comment:3 Changed 5 years ago by Steven Hahn

  • Status changed from new to inprogress

Refs #11692. Add third argument to our_run_code().

Changeset: a27e9e60c341bc18c75c6e36cea644a6cac916f4

comment:4 Changed 5 years ago by Steven Hahn

Refs #11692. Remove exception warning with ipython 2.

Changeset: 135835213e0928a502e6133062a4c8eb2ccb36d4

comment:5 Changed 5 years ago by Steven Hahn

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #712.

comment:6 Changed 5 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:7 Changed 5 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #712 from mantidproject/11692_ipython_3_fix

update our_run_code() for iPython 3+

Full changeset: a968db288fa2bc55e57a5e72bd698b7b8c2555ba

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12530

Note: See TracTickets for help on using tickets.