Colour maps in VSI

[Owen Arnold]

We have major issues with synchronisation of colour bars in the VSI. Nick has seen more of these issues first-hand:

From Nick

Colour map limits in the colour map editor did not interact well with the scaling in the VSI window.  Often you would have the colour map graph 90% to 95% compressed to the max value.

The issue seems to be triggered by switching views and or using the colour editors in-built with the filters.

[Federico Montesino Pouzols]

add m_ prefix, no effective code changes, re #11706

Changeset: 340ae86044a365ec0fc326ddd88bcd0a684ffc2f

[Federico Montesino Pouzols]

define, install callback ParaQ color edit -> ColorSelection, re #11706

Changeset: 782fd8643760f7c97b2e9f612b9bb045783c3e57

[Federico Montesino Pouzols]

put back missing header and use vtk SafeDownCast, re #11706

Changeset: 811369ee25169b1ee35031e869ce37bc30c4f6d1

[Federico Montesino Pouzols]

This is being verified as ​pull request #746.

[Federico Montesino Pouzols]

document unused parameters to make Doxygen happy, re #11706

Changeset: fd2feea3870ccfc3833b475a132a32115f154f69

[Federico Montesino Pouzols]

I'm going to see if we can also keep the checkbox "auto color scaling" in sync with the Paraview map editor. That should be coming in a next commit a bit later today...

[Federico Montesino Pouzols]

update auto-scale check box if changes in the color editor, re #11706

Changeset: 4e2ea6e29c5c2fa64fdbb0907ce4b3fb72589eb2

[Federico Montesino Pouzols]

I think the "auto color scaling" check box behaves well now (in sync with the Paraview color map editor).

But maybe we should still have a chat. Now that the VSI simple ColorSelectionWidget is updated by the ParaQ color map values, it turns out that we get different color ranges when switching between views. My first guess would be that we still want to enforce the default VSI auto-scale initially on all the views? Or is it better to use the scale that the ParaQ color editor produces by default?

I also noticed another oddity. This is in "use log" tick boxes. They are connected "left to right" but not "right to left". This could be easy to fix, if only I could find what vtk property is involved in that log scale check box.

[Federico Montesino Pouzols]

fix abs ambiguity issue with some compilers, re #11706

Changeset: 493cdc3eb7a277fe55fce11ff7285fd7981b1999

[Federico Montesino Pouzols]

add cmath include for the fabs ambiguity, re #11706

Changeset: eebe1459d07c98a93989ac05204ec4a3390122c1

[Federico Montesino Pouzols]

Aha, I think I can have the log-scale issue fixed a bit later today still in time for tonight's build.

[Roman Tolchenov]

Can I start testing?

[Federico Montesino Pouzols]

also sync the log-state from paraview to vsi color widget, re #11706

Changeset: 0563c6d0b7b811c7ed76b372a3fb0e24eca79b7b

[Federico Montesino Pouzols]

keep auto-scale color state when switching views, re #11706

Changeset: b3b5013abca7b0892f0e6e36efeec4fdbc4e85ab

[Federico Montesino Pouzols]

disable color callbacks when needed, re #11706

Changeset: 1ce89f6caa86fadaf00ada63d5b4e01264173f38

[Federico Montesino Pouzols]

I think this should be ready now. The last commits should have:

• fixed the issue with the log-scale check boxes
• mitigated the issue with the auto-scaled colors when switching views

About the second point we still have a glitch when you switch to the multislice view. You'll often lose the auto-scale state, so the user needs to click again on 'auto scale' if it wants the default vsi auto range instead of the Paraview range. If I don't find a very last minute solution for this, it will have to be a new ticket to sort out later.

[Federico Montesino Pouzols]

fix doxygen param line, re #11706

Changeset: 4b6f17c46693f271673a710c78009012f8507283

[Federico Montesino Pouzols]

The windows failure is an unrelated issue of one of the CI machines.

[Federico Montesino Pouzols]

I'm going to merge the latest master and see if everything is still fine.

[Federico Montesino Pouzols]

fix issue after merge, just m_ prefix, re #11706

Changeset: d4deac8aadce2c5544cc9d9c9fda218473423d96

[Federico Montesino Pouzols]

Merge branch 'master' into 11706_color_map_vsi_link_color_map_editor_to_color_selection_widget_lineedits

Conflicts:

Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/MdViewerWidget.cpp

Sort out merge conflict from when we moved setBackgroundColor to the bottom of switchViews, re #11706

Changeset: d489cf7c71d95c19f3243ca9096caede94b1e89f

[Stuart Campbell]

This ticket has been transferred to github issue ​12544