Ticket #11740 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fixes for files with no instrument in IDA and Bayes

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez

Description

From Spencer: 

If I comments out CheckAnalysers, then:
I(q,t) work fine
Quasi fails because there's no Efixed when it tries to run getEfixed in IndirectCommon.
In IndirectCommon for getThetaQ, lines 167-9 should be after 174
In IndirectBayes lines 188 & 727 & 885, calling getEfixed is redundant as GetThetaQ does it.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fix issue in TransformToIqt

Refs #11740

Changeset: e44eed88a940f8958d6f7464a2c5c430783d929e

comment:3 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #737.

comment:4 Changed 5 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:5 Changed 5 years ago by Dan Nixon

The issues with Bayes will take longer to resolve that there is left before the cut off point for bug fixes.

comment:6 Changed 5 years ago by Raquel Alvarez

Build failed on windows due to unrelated NormaliseByCurrent-v1 doc test.

comment:7 Changed 5 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #737 from mantidproject/11740_ida_bayes_no_inst_fix

Fix issues with data with no instrument in IDA

Full changeset: ​0a2c5de72fae9647bc8052f1f2eb3c1487f57e84

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12578

Note: See TracTickets for help on using tickets.