Ticket #11754 (closed: fixed)
Update class_maker.py to generate code following current standards
| Reported by: | Nick Draper | Owned by: | Raquel Alvarez Banos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | Tools | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Dan Nixon |
Description
The code that class make generates does not fit all of our current coding standards.
- clang format
- Naming
- all definitions in cpp
It should be improved to show the gold standard we should all follow
Change History
comment:2 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Return string + clang format
Changeset: bc0fe7c489acf7da3b9ab36b862ff63ec29a3972
comment:3 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Header clang format
Changeset: 6a7064aa8a66e9e827dfe31a8c16b6bfaca5c703
comment:4 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Clang format to unit test
Changeset: e68a6515f322438c1104964cde82ef6c3ebb309d
comment:5 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Remove test classes from make file
Changeset: 876349e1165bf2ee363c11f144bbe8f5f1fd4bb4
comment:6 Changed 5 years ago by Raquel Alvarez
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #762.
comment:7 Changed 5 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:8 Changed 5 years ago by Dan Nixon
The only extra thing I can think that this could do with having is a note reminding the developer to subclass DataProcessorAlgorithm when the algorithm is a workflow algorithm.
comment:9 Changed 5 years ago by Federico Montesino Pouzols
Maybe another useful reminder could be added about processGroups() which you need to override when your algorithm operates on a WorkspaceGroup?
comment:10 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Add reminders
Changeset: 50ff5e8ed305904b8382cd8493c8569a9144751a
comment:11 Changed 5 years ago by Raquel Alvarez
Thanks for the comments! the two reminders have been added, they are printed when class_maker is run with --alg.
comment:12 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Update class source according to clang format
Changeset: c0f2d99e0cea0ee9a511d6b28b971352f7037c03
comment:13 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Return string + clang format
Changeset: bc0fe7c489acf7da3b9ab36b862ff63ec29a3972
comment:14 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Header clang format
Changeset: 6a7064aa8a66e9e827dfe31a8c16b6bfaca5c703
comment:15 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Clang format to unit test
Changeset: e68a6515f322438c1104964cde82ef6c3ebb309d
comment:16 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Remove test classes from make file
Changeset: 876349e1165bf2ee363c11f144bbe8f5f1fd4bb4
comment:17 Changed 5 years ago by Raquel Alvarez Banos
Re #11754 Add reminders
Changeset: 50ff5e8ed305904b8382cd8493c8569a9144751a
comment:18 Changed 5 years ago by Dan Nixon
- Status changed from verifying to closed
Merge pull request #762 from mantidproject/11754_Update_class_maker
Update class_maker.py
Full changeset: 6e7c980670ef01a428f1e02d43fd9aeb195efc1f
comment:19 Changed 5 years ago by Dan Nixon
Looks good, I'll not bother waiting for the CI since this isn't included in it.
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12592
Re #11754 Update class source according to clang format
Changeset: c0f2d99e0cea0ee9a511d6b28b971352f7037c03