Ticket #11756 (closed: fixed)
Add LINK_PRIVATE where possible in CMake
Reported by: | Nick Draper | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | major | Milestone: | Release 3.5 |
Component: | Tools | Keywords: | Maintenance |
Cc: | Blocked By: | ||
Blocking: | Tester: | Harry Jeffery |
Description
This limits the linking of libraries to only the places they are required and should speed up linking in the build.
Change History
comment:2 Changed 5 years ago by Roman Tolchenov
Re #11756. Done MantidQt
Changeset: 5a18e4c9962332e363bd48a4a0d7f839cc6ef6f6
comment:3 Changed 5 years ago by Roman Tolchenov
Re #11756. Done unit tests.
Changeset: 6b30a4b52a6f92d6c5b32da11cadc396c1351343
comment:4 Changed 5 years ago by Roman Tolchenov
Re #11756. Done MantidPlot and RefDetectorViewer.
Changeset: 381b60bd02932bb7962adf1350d76f9b10ac3e4d
comment:5 Changed 5 years ago by Roman Tolchenov
Merge branch 'master' into 11756_add_link_private_to_cmakelists Re #11756
Changeset: 38caeb44f10197b2ed0fbc2651b2a870c0ce31b6
comment:6 Changed 5 years ago by Roman Tolchenov
Re #11756. Added OpenGL libraries to MantidPlot.
Changeset: 967988c5dd936a157707e41b695baf6beee0f49d
comment:7 Changed 5 years ago by Roman Tolchenov
Re #11756. Replaced tabs with spaces.
Changeset: 81a10d5dca6e6da5f1b0183af83056a2d6a9594a
comment:8 Changed 5 years ago by Roman Tolchenov
Re #11756. Added a library.
Changeset: 636c2eb2df915e6e4d4d11e2698b07a6c7fd36c2
comment:9 Changed 5 years ago by Roman Tolchenov
Re #11756. Done vates.
Changeset: 74aa966600cf7534543bbed2bddeed7a62032c66
comment:10 Changed 5 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #779.
comment:11 Changed 5 years ago by Roman Tolchenov
Re #11756. Trying to fix the OSX issues.
Changeset: 68c1e6f28ffb7f6c61fb5a15cffa07136e3b18aa
comment:12 Changed 5 years ago by Roman Tolchenov
Re #11756. Trying to avoid linking to qscintilla.
Changeset: 0072755fc2a15faa2af11d29980865572063e6f8
comment:13 Changed 5 years ago by Roman Tolchenov
Re #11756. Fix a gcc warning.
Changeset: 8a4b03e87880ab505998701ca53aae0874b5fa72
comment:14 Changed 5 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:15 Changed 5 years ago by Harry Jeffery
- Full clean build works
- Linking time has improved a bit:
- Measured with: ninja -j8; rm bin/*.so; time ninja -j8
- Before: 66.18s user 4.12s system 512% cpu 13.708 total
- After: 51.24s user 3.79s system 541% cpu 10.168 total
- The resulting binaries have not changed in size
comment:16 Changed 5 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #779 from mantidproject/11756_add_link_private_to_cmakelists
Add LINK_PRIVATE where possible in CMake
Full changeset: 01814ae4aabc8e357f67e02137f0e6461214344c
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12594
Re #11756. Added LINK_PRIVATE to cmakelists. Compiled framework in vc.
Changeset: 53679b9cff1c6b7f3831e4d927db2d9eb8b7d410