Ticket #11775 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Set correct background color when switching between views in the VSI

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Anton Piccardo-Selg

Description

We found an issue when switching between views: the background color is remembered from before and not updated to the current user selection.

Change History

comment:1 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from new to inprogress

set correct backgroun color after reloading view state, re #11775

Changeset: 40e96fcfa891f878c6929497566f9a852d3d97c8

comment:2 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #758.

comment:3 Changed 5 years ago by Federico Montesino Pouzols

This is not a terribly critical bug but as it is a low risk change which definitely seems to fix the issue, it would be good if it's included for 3.4.

comment:4 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from verify to verifying
  • Tester set to Anton Piccardo-Selg

comment:5 Changed 5 years ago by Anton Piccardo-Selg

The background color seems to be behaving as it used to. When the user changes the background color in the properties panel, his changes are carried over to the new view. The fix seems to solve the issue.

I saw another issue though: The rendered area of the MultiSliceView is not fully displayed, but rather cut off at the bottom.

comment:6 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from verifying to closed

Merge pull request #758 from mantidproject/11775_vsi_set_correct_background_color_when_switching_views

VSI: set correct background color when switching views

Full changeset: ​89184fec5ab5f5076edf4f57285169b4d083b7c6

comment:7 Changed 5 years ago by Federico Montesino Pouzols

I've just created a couple of tickets for this "cut off" issue and the related "window resize" issue which by the way doesn't seem to happen to the MultiSlice view which somehow is resized properly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12613

Note: See TracTickets for help on using tickets.