Ticket #11809 (closed)
Change SensorA as default log in IDA.ELWIN for BASIS
| Reported by: | Jose Borreguero | Owned by: | Jose Borreguero |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.5 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | daniel.nixon@… | Blocked By: | |
| Blocking: | Tester: | Dan Nixon |
Description
The current default log is SetpoinLP1, which is not the measured sample temperature, but the theoretical expected sample temperature. Both quantities can differ by as much as 15K !
Also, SetpointLP1 is a single value, while SensorA is a series. If sensorA is selected, then the minimum value is taken as representative of the series. Instead, the average is desired.
Change History
comment:2 Changed 5 years ago by Jose Borreguero
- Status changed from assigned to inprogress
Refs #11809 Switched from SetpointLP1 to SensorA
Changeset: 5ee346a117349f970894b41a5943a22b542dcfbc
comment:4 Changed 5 years ago by Jose Borreguero
Dear Spencer:
Algorithm ElasticWindowMultiple (the backend of the IDA.ELWIN tab) sets the temperature of an elastic run as the last value in the recorded series of temperature values (see line 321 of script ElasticWindowMultiple.py). Isn't it much more reasonable to select the average of the series, instead? This observation was reported by one of our instrument scientists.
comment:5 Changed 5 years ago by Jose Borreguero
Refs #11809 Added log value option
Changeset: 81f1cb8722610ccd7b593a9c6b4c552a88aba36b
comment:7 Changed 5 years ago by Jose Borreguero
Refs #11809 Undo small change for debugging purposes
Changeset: bb95140b3ac8a01b8a8d223c61ffe3d28a457b1d
comment:9 Changed 5 years ago by Dan Nixon
- Status changed from inprogress to verifying
- Tester set to Dan Nixon
comment:10 Changed 5 years ago by Dan Nixon
The changes work as expected but could you update the [UI docs](https://github.com/mantidproject/mantid/blob/11809_BASISSensorA/Code/Mantid/docs/source/interfaces/Indirect_DataAnalysis.rst) to include the new option.
comment:11 Changed 5 years ago by Jose Borreguero
Refs #11809 Update docs
Changeset: f97ba8acc1c92a72f8c0b949bf8ec916429cf1ac
comment:12 Changed 5 years ago by Dan Nixon
The Windows test failure is unrelated.
comment:13 Changed 5 years ago by Dan Nixon
- Status changed from verifying to closed
Merge pull request #795 from mantidproject/11809_BASISSensorA
Change SensorA as default log in IDA.ELWIN for BASIS
Full changeset: c145bcf0e87f27e7171b4ee9bd4f579c4e0b053b
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12647
