Ticket #11812 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

NO_OPENCASCADE still used in CMakeLists

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: minor Milestone: Release 3.5
Component: Tools Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Geometry's CMakeLists.txt still has a reference to NO_OPENCASCADE. This should be replaced.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

Refs #11812 Don't rely on non-existent variable

Changeset: 0a89aaa949eade1dfa3a408fc48c56292168589f

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #777.

comment:3 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:4 Changed 5 years ago by Federico Montesino Pouzols

I couldn't find any NO_OPENCASCADE remainings. It looks good and cmake seems to behave well.

comment:5 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #777 from mantidproject/11812_no_opencascade_still_used

Fix incorrect NO_OPENCASCADE reference

Full changeset: ​9c1409b625833654edc5bea06a7d0d79790ed921

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12650

Note: See TracTickets for help on using tickets.