Ticket #11814 (closed: fixed)
Set the Recursion Depth for MDEvent workspaces to 1 when top level splitting is applied.
| Reported by: | Anton Piccardo-Selg | Owned by: | Anton Piccardo-Selg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | GUI | Keywords: | VATES |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
When we are loading an MDEvent workspace with an applied top level splitting we want to set the recursion depth to 1 instead of the current value of 5.
Attachments
Change History
comment:2 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Correct the display of the rec. depth in plugin
Changeset: ff8aabdf20689a5dbc3d61ce0ff7955b5792df5d
comment:3 Changed 5 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #781.
comment:4 Changed 5 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 5 years ago by Owen Arnold
Could you please add something to the release notes about these changes. Probably to bug fixes http://www.mantidproject.org/ReleaseNotes_3_5_UI_Changes
comment:6 Changed 5 years ago by Anton Piccardo-Selg
Added information regarding these changes to the release notes
comment:7 Changed 5 years ago by Owen Arnold
Functionally correct. Some refactoring changes proposed.
comment:8 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Refactoring of top level split check
Changeset: d18fe6aec5e6c9d2543b6a5ade75a1d3bc449fd2
comment:9 Changed 5 years ago by Anton Piccardo-Selg
Refactored the check for top level splitting. The refactored function is directly called from within [MDEWSource](https://github.com/mantidproject/mantid/blob/feature/11814_set_recursion_depth_for_top_level_split_to_1/Code/Mantid/Vates/ParaviewPlugins/ParaViewSources/MDEWSource/vtkMDEWSource.cxx#L237:L239) and [ViewBase](https://github.com/mantidproject/mantid/blob/feature/11814_set_recursion_depth_for_top_level_split_to_1/Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp#L302:L305). In the former case we are not going through the presenter, as this is a generic interface for both MDEvent- and MDHisto-based sources, whereas the recursion depth is only applicable for MDEvent-based sources.
comment:10 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 make unit test more efficient
Changeset: 191ad691d07193331863c4c9b5974cc53ede07a6
comment:11 Changed 5 years ago by Anton Piccardo-Selg
- Changed the include guards
- Changed the unit test for MDEvent data with top level splitting
comment:12 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Fix merge issues
Changeset: 167c2993aeff63a2ce0de9afc8e493d694e3d918
comment:13 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Fix doxygen warning
Changeset: 0f58574ea3edf904f00923d47de52fb752db2bce
comment:14 Changed 5 years ago by Anton Piccardo-Selg
RHEL6 build seems to be a gcc4 [issue](https://bugzilla.redhat.com/show_bug.cgi?id=531483)
comment:15 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Try to silence gcc4.4 warning for boost optional
Changeset: 7e2d871520f060f096a431b0550c99183304f5dc
comment:16 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Change gcc pragmas
Changeset: cf3b62bfd4d7e2d7d229dae2eed419b09d73b230
comment:17 Changed 5 years ago by Anton Piccardo-Selg
Refs #11814 Refactor pragmas
Changeset: 5b63dd8d3a9e19e7498d0cd6c2efb25ce359ca80
comment:18 Changed 5 years ago by Owen Arnold
- Status changed from verifying to closed
Merge pull request #781 from mantidproject/feature/11814_set_recursion_depth_for_top_level_split_to_1
Set recursion depth for top level split to 1
Full changeset: 1216797cfa144380958d11173224bb65b44cd7cd
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12652
Refs #11814 Change recursion depth to 1 when using top level split
Changeset: ec6b4b1f770a39dafe1bc597f493527ea55cfb0a