Whitelist DLLs for Windows package

[Martyn Gigg]

The Windows package contains quite a few libraries, mostly debug variants, that shouldn't be there. They are bloating the installer by ~40Mb. Now that we have included ParaView it would be good to reduce this down.

The current packaging script just pulls in most dlls from third party with a few exceptions using a glob. We should have more control over what is added and define a whitelist of dlls to include.

[Martyn Gigg]

Define a list of third party dlls to deploy

This will avoid accidentally dropping something into the repository and having it automatically included in the package. Refs #11857

Changeset: ef54154b31c41c626ddfabe584575c4aaeef23ed

[Martyn Gigg]

Clean up the formatting.

Refs #11857

Changeset: 697074346f507e5b51f3a9379beaad6ed6d34cbf

[Martyn Gigg]

Define a list of third party dlls to deploy

This will avoid accidentally dropping something into the repository and having it automatically included in the package. Refs #11857

Changeset: b9e1b202b626366156d39557103495bae2c0b4b0

[Martyn Gigg]

Clean up the formatting.

Refs #11857

Changeset: 2ee56380a96cc1dff5872ef7c3393db8916aee8b

[Martyn Gigg]

This is being verified as ​pull request #803.

[Martyn Gigg]

The doc tests failure is just the unreliable DownloadFile failure and not related to these changes.

[Federico Montesino Pouzols]

DownloadFileTest strikes back, but the package has been built successfully on isis-ndw1490 and should be there (unless it is removed after the doc-test failure). Is there any way to get it? I can't find anything through the Jenkins Workspace etc.

I noticed that CPack is taking over 10 minutes even after these changes.

[Federico Montesino Pouzols]

Oh sorry, now I can see it. But it seems to be around 181 MB.

[Martyn Gigg]

I see what has happened now. My test build didn't include the documentation, which actually accounts for the 40Mb :( Despite this, I think the changes are still worthwhile as it will prevent new dlls that are added the the Third Party from being included unless they are specifically requested.

[Federico Montesino Pouzols]

The win64 package installs well, and I could not see any issues that should have been obvious if there was anything wrong with the dlls. So let's merge it in. This should produce cleaner installations and also a smaller package even if the gain cannot be that big.

The release notes will need an update if it's not feasible to shrink the package that much.

[Martyn Gigg]

Define a list of third party dlls to deploy

This will avoid accidentally dropping something into the repository and having it automatically included in the package. Refs #11857

Changeset: b9e1b202b626366156d39557103495bae2c0b4b0

[Martyn Gigg]

Clean up the formatting.

Refs #11857

Changeset: 2ee56380a96cc1dff5872ef7c3393db8916aee8b

[Federico Montesino Pouzols]

Merge pull request #803 from mantidproject/11857_whitelist_win_package_dlls

Whitelist dlls for Windows package

Full changeset: ​5c744fa628ddf9ef9a8c134029e04f4b21dc9c0e

[Martyn Gigg]

Good point. I'll update the notes to remove the entry as it's now more of a maintenance.

[Stuart Campbell]

This ticket has been transferred to github issue ​12695