Ticket #11859 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Add Python version of cylinder abs. code

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.5
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Spencer has done the work porting this from Fortran, this should be added as a new version of the current CylinderPaalmanPingsAbsorption algorithm.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Cc spencer.howells@… added
  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add refactored algorithm Refs #11859

Changeset: 102ca4adc4fb73f14da98a2124bb227df6ffc4da

comment:3 Changed 5 years ago by Dan Nixon

Add new test suite for new algorithm version

Refs #11859

Changeset: c57ac0647e4ab70938685d65f9afa8cd2c581ad5

comment:4 Changed 5 years ago by Dan Nixon

Add doc page, with usage example Refs #11859

Changeset: 077b8be3e7c1fcf883b432e7c0b42528f909c68d

comment:5 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #798.

comment:6 Changed 5 years ago by Dan Nixon

Re add interpolation option

Refs #11859

Changeset: 00fb2c426fb4dd60a20bb85539ac6bc224d7ce86

comment:7 Changed 5 years ago by Dan Nixon

Actually run the tests on non Windows platforms

Refs #11859

Changeset: 00e218e20100128898264d28f7f20dfd8795208d

comment:8 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11859_new_cylinder_abscor_algo

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/CylinderPaalmanPingsCorrection.py

Refs #11859

Changeset: e54ce263ca16e23af040da4dd3237ea9f2b3440c

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:10 Changed 5 years ago by Federico Montesino Pouzols

There's a pylint warning in CylinderPaalmanPingsCorrection2.py: attribute '_interpolate' defined outside init. Maybe this just needs one of those pylint-ignore directives? Anyway if there's going to be follow-up work on IDA where this can be corrected, I'd be tempted to merge...

comment:11 Changed 5 years ago by Dan Nixon

Pylint Refs #11859

Changeset: 869ac3624b21f61aa8f83719f2f69db03642e0a5

comment:12 Changed 5 years ago by Dan Nixon

@FedeMPouzols May as well do it now, I'd only completely forget about it if it was left.

comment:13 Changed 5 years ago by Federico Montesino Pouzols

Oh good! Not bothering to wait for the doc/system tests to run again...

comment:14 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #798 from mantidproject/11859_new_cylinder_abscor_algo

Add Python version of the indirect cylinder absorption correction routine

Full changeset: ​6d43ca223a37efe4f843136077b6563903c9a590

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12697

Note: See TracTickets for help on using tickets.