Ticket #11868 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Move PeakTransform* and IPeak to Geometry from API

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.5
Component: Framework Keywords: vates
Cc: Blocked By:
Blocking: #11872, #11878 Tester: Martyn Gigg

Description

In order to determine if a peak should be deleted when a cursor passes over it exact (x,y and derived z) positions, we need to know if it intersects the peak. The easiest and best way to do this is to utilise the PeakShape of each Peak to return a PeakBoundingBox. Each subtype of Peak should be able to deliver a PeakBoundingBox as it quite a general concept. However, PeakBoundingBox is in Geometry and PeakShape is in the subpackage API. This ticket is concerned with moving the SC Peak transform and shape components into Mantid Geometry Crystal.

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11868. partially completed

Changeset: eb7071125c227acfb9ed1f7d253394fb670bc999

comment:2 Changed 5 years ago by Owen Arnold

refs #11868. Complete move

Changeset: 5f008949d28b6989d77730ce09d216b4e8c8f25f

comment:3 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #824.

comment:4 Changed 5 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 5 years ago by Owen Arnold

  • Blocking 11872 added

comment:6 Changed 5 years ago by Martyn Gigg

The documentation tests failure is spurious.

comment:7 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #824 from mantidproject/11868_relocate

Move Peak Classes to Geometry Crystal Subpackage

Full changeset: 708c0cf4d0471fd3ad38f2fac49b8510f39116dc

comment:8 Changed 5 years ago by Owen Arnold

  • Blocking 11878 added

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12706

Note: See TracTickets for help on using tickets.