Ticket #1186 (assigned)
Review object/surface intercept testing code
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Backlog |
Component: | Keywords: | ||
Cc: | Blocked By: | ||
Blocking: | Tester: |
Description
Currently the track interception methods contain some magic values that used to shift points, i.e. in the Object::calcValidType method
const Geometry::V3D shift(uVec*Surface::getSurfaceTolerance()*25.0);
The value of 25 seems arbitrary and shouldn't need to be this large, a value of just over 1 should suffice.
The interception methods are rather sensitive to these values a review of this code is necessary to improve their accuracy.
Change History
comment:2 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:3 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:4 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
"New" tickets moved at the code freeze of iteration 29
comment:5 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:7 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:9 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:11 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:12 Changed 7 years ago by Martyn Gigg
- Milestone changed from Release 2.6 to Release 2.7
Batch move to 2.7
comment:14 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2033
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.