Ticket #1226 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

ReplaceSpecialVales performance improvement

Reported by: Nick Draper Owned by: Russell Taylor
Priority: major Milestone: Iteration 23
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

  1. read a raw file in to w1
  2. Run ReplaceSpecialValues with OutputW same as inputW

First of all, this operation on a WISH data set takes about 9 sec,i.e. as long as some of the most intensive algorithm such as DiffractionFocussing ???? That needs to be fixed.

Secondly, as far as I know this Algo. does not affect the X values but only the Y and E. If so, the memory footprint should be the same before and after, but is not: 10G before, 14G after. It sounds to me like a lot of unnecessary copying is going on.

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [4396]) Preserve any X data sharing in UnaryOperation algorithms (including ReplaceSpecialValues). Re #1226.

comment:3 Changed 10 years ago by Russell Taylor

(In [4421]) Make UnaryOperation multi-threaded. Also unlocked reading of ParameterMap cache and fix bug in Cache updating code. Re #1226.

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 10 years ago by Sofia Antony

  • Status changed from testing to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2073

Note: See TracTickets for help on using tickets.