Ticket #1261 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS: Add a tab on the GUI for summing raw files into -add files

Reported by: Martyn Gigg Owned by: Steve Williams
Priority: critical Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Create a new tab on the SANS GUI so that multiple raw/nexus files can be summed together to produce a processed nexus file. The attached script is the Python module that RKH currently has to do this.

The tab should be able to process multiple batches of runs by having a table where each row specifies the run numbers that will be summed together. The output file name is calculated from the inputs and is in the attached script.

Add a separate Python module call SANSadd to the scripts/SANS directory to do this.

This should all be possible from without the GUI as well.

Attachments

SANSadd2.py (2.1 KB) - added by Martyn Gigg 10 years ago.
22062010.jpg (146.6 KB) - added by Steve Williams 10 years ago.

Change History

Changed 10 years ago by Martyn Gigg

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner set to Steve Williams

comment:2 Changed 10 years ago by Steve Williams

  • Status changed from assigned to accepted
  • Priority changed from major to critical

I estimate 6 hours and so hope to commit it the morning of the 17th July 2010

Changed 10 years ago by Steve Williams

comment:3 Changed 10 years ago by Steve Williams

Nick said that he wants an interface like the attached that also supports commas and hyphens. The requirement to create more than one summed file at a time has been relaxed

comment:4 Changed 10 years ago by Steve Williams

Martyn said that the list shouldn't show full file paths and that the path should be displayed in a tooltip.

comment:5 Changed 10 years ago by Steve Williams

(In [4999]) New widget sums run files into one Nexus file. There is a new Python script PythonAPI/scripts/SANS/SANSadd2.py and GUI that is in the main SANS GUI. A system test for the Python script will follow re #1261

comment:6 Changed 10 years ago by Steve Williams

I had some false starts, we went through a few user interface ideas and changed the specification. Total time spent so far 5.5 days.

A further requirement from Nick was that the GUI shouldn't lock while Python sums the files, so allowing users to add specify more files for the next sum.

comment:7 Changed 10 years ago by Steve Williams

Ensured that extension of the output file was .nxs. Improved error reporing and used the same C++ code to create the run list for the table as for the sum loop. These and other debugs took 5 hours.

comment:8 Changed 10 years ago by Steve Williams

(In [5040]) Tests and corrections for the Add Files widget and its Python re #1261

comment:9 Changed 10 years ago by Steve Williams

(In [5041]) Remove changes from a file that I shouldn't have committed re #1261

comment:10 Changed 10 years ago by Steve Williams

(In [5053]) Add Files widget, fixed nexus files not working, fixed system test re #1261

comment:11 Changed 10 years ago by Steve Williams

Getting LoadRaw and LoadNexus to be called on only the files that they support, fixing another bug, discussing the interface with Steve King and adding some tooltips took an extra 3 hours.

comment:12 Changed 10 years ago by Steve Williams

  • Status changed from accepted to testing
  • Resolution set to fixed

Total 6. days

comment:13 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:14 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:15 Changed 10 years ago by Steve Williams

(In [5885]) The widget that can sum data files into one didn't work when the input files weren't in the search path re #1261

comment:16 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:17 Changed 10 years ago by Steve Williams

(In [5917]) Fix bug dealing with run numbers in the sum files widget re #1261

comment:18 Changed 10 years ago by Steve Williams

  • Status changed from reopened to accepted

Under some circumstances of incompatible workspaces this can crash Mantid. After discussion with Nick this crash is now being handled in this ticket:1519

comment:19 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:21 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2108

Note: See TracTickets for help on using tickets.