Ticket #1264 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS: CanSAS1D update

Reported by: Martyn Gigg Owned by: Steve Williams
Priority: critical Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Sofia Antony

Description

From S. King:

Modify SaveCanSAS1D (and hence LoadCanSAS1D) so that it writes 

<SASentry name="GDW20_3.5m">
<Title>GDW20_3.5m</Title>
<Run>NNNN</Run>
<SASdata>

where NNNN is the sample scattering (SANS) run number.

instead of the current 

<SASentry name="workspace">
<Title></Title>
<Run>GDW20_3.5m</Run>
<SASdata>

This will require attaching the run number of the sample to the reduced workspace in a similar manner to the way we incorporate the MaskFile as a sample log at the moment.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner set to Steve Williams

comment:2 Changed 10 years ago by Steve Williams

Check if they want the run number padded or unpadded.

comment:3 Changed 10 years ago by Steve Williams

From Nick, all workspace should save their run number if possible on loading (from LoadRaw or LoadNexus). In the unusual situation were there is no run number the entry can be blank.

comment:4 Changed 10 years ago by Steve Williams

  • Priority changed from major to critical

Needs ticket #1354 to be solved for the <title> element to work.

comment:5 Changed 10 years ago by Steve Williams

(In [5088]) SaveCanSAS1D now stores the run number. Currently it is stored via a Python, storage via load algorithms will follow re #1264

comment:6 Changed 10 years ago by Russell Taylor

(In [5093]) Remove debugging code from test. Re #1264.

comment:7 Changed 10 years ago by Steve Williams

(In [5104]) All Load*Nexus algorithms and LoadRaw now read the run number and store it in the sample logs of all the matrix workspaces they create. re #1264 fixes #1354

comment:8 Changed 10 years ago by Steve Williams

  • Status changed from assigned to testing
  • Resolution set to fixed

comment:9 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:10 Changed 10 years ago by Sofia Antony

  • Status changed from verify to verifying
  • Tester set to Sofia Antony

comment:11 Changed 10 years ago by Sofia Antony

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2111

Note: See TracTickets for help on using tickets.