Ticket #1289 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Why do workspace groups contain their own names?

Reported by: Roman Tolchenov Owned by: Sofia Antony
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description


Change History

comment:1 Changed 10 years ago by Sofia Antony

(In [6491]) re#1289 - group name is removed from workspace group vector in the Workspacegroup class and changed algorithms which uses group vectors and iterates over it. After installing visual studio 2010, unit testing is not working for all categories of algorithms on my machine, some of the unit tests may break after this check-in.

comment:2 Changed 10 years ago by Sofia Antony

(In [6494]) re#1289 - Fix for unit test failure.Both files were counting the no.of group workspace name along with the group members.

comment:3 Changed 10 years ago by Sofia Antony

(In [6495]) re#1289 - Fix for unit test failure.SaveCanSAS1DTest,WorkspaceGroupTest fixed. One of the tests of GroupWorkspacesTest is still failing for me,temporarily commented the test which failed.

comment:4 Changed 10 years ago by Sofia Antony

(In [6496]) re#1289 - Fix for unit test failure.

comment:5 Changed 10 years ago by Sofia Antony

(In [6497]) re#1289 - Fix for unit test failure.GroupWorkspacesTest is enabling back.

comment:6 Changed 10 years ago by Sofia Antony

  • Status changed from new to accepted
  • Component set to Mantid

comment:7 Changed 10 years ago by Sofia Antony

(In [6521]) re#1289 - fix for MantidPlot crash on deleting WorkspaceGroup

comment:8 Changed 10 years ago by Sofia Antony

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:10 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

Fixed in [7139]

Workspace groups no longer return their own name when getNames() function is called on them, as evidenced by running this python script on [7139] and [5988]

LoadRaw('irs21360.raw', '1')
LoadRaw('irs21360.raw', '2')
LoadRaw('irs21360.raw', '3')
GroupWorkspaces('grp','1,2,3')
grp = mtd['grp']
print grp.getNames()

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2136

Note: See TracTickets for help on using tickets.