Ticket #1307 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Adjust fitting parameters for HRPD and GEM to owrk with d-spacing

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

As discussed in the meeting, just adjust the values and functions to work for d-psacing rather than TOF.

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [4830]) Converted Back-to-Back exponential parameters to output in d-spacing units. Also, adjusted peak shape function such that when more than 10 sigma away from centre of peak zero is returned. Tests indicate that fitting multiple HRPD peaks are now even faster. Refs #1307.

comment:2 Changed 10 years ago by Anders Markvardsen

(In [4831]) Updated test. Note there is room to be more clever than the simple cutoff of 10*sigma for the Back-to-Back exponential, since the alpha and beta parameter also affects this width. Also for speed efficiently would we want the user to be able to specify a cutoff as is done with e.g. Fullprof? 10*sigma corresponds to the most conservative cutoff used when analysing HRPD data with Fullprof. Refs #1307.

comment:3 Changed 10 years ago by Anders Markvardsen

(In [4834]) Fix broken test in previous commit to this ticket. Refs #1307.

comment:4 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

Although done, this was a temporary fix at the time, since with automatic unit conversion now implemented (#1308) it does not matter what unit parameters are specified in (they get converted as needed).

comment:5 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify

comment:6 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:7 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2154

Note: See TracTickets for help on using tickets.